Batch redraws for mithril timers bench #8
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mithril timers bench is now almost twice as fast then Oval 😝
According to Mithril's documentation:
Unfortunately that doesn't seems to happen when
m.redraw
is called multiple times inside each and every timeout. So instead I'm batching the redraws manually.Mithril doesn't have the concept of redrawing a single component, instead it have only one redraw cycle, and that is the global one. So from Mithril's point of view this fix isn't even a hack, but you can try similar approach with Oval and see how it compares.