fix: add exceptions to the orphaned resources warning #115
+44
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
In all our Argo CD projects definitions we have enabled the warning for orphaned resources. I consider this is to be a good practice in order to be warned of rogue resources on the applications' namespaces.
However, I noticed that we are also being warned about resources that are legitimately created by other utilities than Argo CD. For example, all the Argo CD resources for each of the DevOps Stack modules are created using Terraform, so Argo CD considers them orphaned. The same thing will apply to all the secrets created using the External Secrets operator.
This PR adds exceptions on the resources that should not be tracked by Argo CD. Check ISDEVOPS-304 for more information.
Breaking change
Tests executed on which distribution(s)