Skip to content
This repository has been archived by the owner on Apr 16, 2019. It is now read-only.

A script to run gulp through docker #13

Closed
wants to merge 1 commit into from
Closed

A script to run gulp through docker #13

wants to merge 1 commit into from

Conversation

nottrobin
Copy link
Contributor

Make use of ubuntudesign/node to build docs and run gulp in a nice simple encapsulated way.

This is sort of experimental. It occurred to me that ubuntudesign/node does give us a simple way to encapsulate node dependencies pretty easily. So this is just a sort of prototype for how to do that well.

QA

./run-gulp

After installing dependencies, the site should be running on http://localhost:3000.

@deadlight
Copy link
Contributor

@nottrobin

./run-gulp
Unable to find image 'ubuntudesign/node:latest' locally
latest: Pulling from ubuntudesign/node
357ea8c3d80b: Already exists 
52befadefd24: Already exists 
47e99d7dcd4f: Already exists 
cc0efb4b19dd: Already exists 
31855431f6c0: Pull complete 
9703ce929a62: Pull complete 
8070e70c410b: Pull complete 
6af841369c01: Pull complete 
1a0632136671: Pull complete 
Digest: sha256:a1b3346d27e6a53fc937be63ba94eb0be3a6e7991d4022cd9dadedbfa189f0a6
Status: Downloaded newer image for ubuntudesign/node:latest
Warning: package.json not found. Not installing node dependencies.
/entrypoint: line 20: gulp: command not found

@deadlight
Copy link
Contributor

@nottrobin:

./run-gulp
Warning: package.json not found. Not installing node dependencies.
/entrypoint: line 20: gulp: command not found

@nottrobin
Copy link
Contributor Author

@deadlight try again?

@deadlight
Copy link
Contributor

@nottrobin fresh checkout - had some weird merge issues:

[BS] Serving files from: ./build

events.js:160
      throw er; // Unhandled 'error' event
      ^
Error: scss/pattern-lib.scss
Error: File to import not found or unreadable: vanilla-framework/scss/vanilla
       Parent style sheet: /app/scss/pattern-lib.scss
        on line 1 of scss/pattern-lib.scss
>> @import 'vanilla-framework/scss/vanilla';
   ^

    at options.error (/packages/node_modules/node-sass/lib/index.js:272:32)

Make use of ubuntudesign/node to build docs and run gulp in a nice simple encapsulated way.

- run-gulp encapsulated two docker commands for runing "gulp import-docs" and "gulp develop"
- node_modules should no longer be created locally, so dont ignore it
- npm-debug.log or whatever should be ignored
@nottrobin
Copy link
Contributor Author

I hope that should be fixed by the previous PR, which I've now rebased on top of. @deadlight try again when you get a chance?

@nottrobin
Copy link
Contributor Author

@deadlight okay this won't work until this feature is published in the new release of node-sass.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants