Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable extra parameters to be passed to the renderer #42

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Enable extra parameters to be passed to the renderer #42

merged 2 commits into from
Nov 30, 2022

Conversation

VariableDeclared
Copy link
Contributor

Enable TLS for beats integration.

Releated PR

@VariableDeclared VariableDeclared mentioned this pull request Nov 22, 2022
Merged
@VariableDeclared
Copy link
Contributor Author

Took a look at the error above. There are breaking changes in Py3.10:

https://bobbyhadz.com/blog/python-attributeerror-module-collections-has-no-attribute-callable

@agileshaw
Copy link
Contributor

It appears that the test is broken because of nose dependency (https:/juju-solutions/layer-beats-base/blob/master/tox.ini#L62) not supporting Python 3.10. The last release of nose package is more than 7 years ago (2015), so we need drop this package and start use pytest instead.

@esunar
Copy link

esunar commented Nov 30, 2022

I have fixed the nose issue by upgrading it to nose3

@agileshaw agileshaw merged commit 8d9e312 into canonical:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esunar esunar esunar approved these changes

@agileshaw agileshaw agileshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VariableDeclared @agileshaw @esunar