snapcraft/commands: Fix check for first execution during daemon start #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boltmark please can you add a test for this behaviour to lxd-ci , https:/canonical/lxd-ci/blob/main/tests/snapd looks relevant place. @simondeziel please can you ensure this is included in your 5.0 core22 PR in case the bug commit has been included. Ta |
This reverts commit 14cf45b. Signed-off-by: Mark Bolton <[email protected]>
boltmark
force-pushed
the
fix-snap-preseed
branch
from
43f1b0e
to
39bd791
Compare
tomponline
approved these changes
Jul 26, 2024
|
Thanks! just the lxd-ci test for this now then please |
tomponline
added a commit
that referenced
this pull request
Aug 20, 2024
- Fix Dell Powerflex migrations from canonical/lxd#13934 - Fix snap preseed support from #532 - Fix snapshot importing from canonical/lxd#13899
tomponline
added a commit
that referenced
this pull request
Aug 20, 2024
- Fix Dell Powerflex migrations from canonical/lxd#13934 - Fix snap preseed support from #532 - Fix snapshot importing from canonical/lxd#13899 - Vendor apparmor and cherry-pick Oracular container fixes from #534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the point at which we check if it is the first lxd start in
daemon.start. We are currently making this check after we begin the process of starting lxd, which means the check will always fail. This PR ensures we make the check before we start lxd.Fixes canonical/lxd#13818.