-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v13.6.2->13.7.0 missing some of my events from vue app #1409
Comments
@capricorn86 I'm facing the same issue, some changes added in v13.7.0 broke a bunch of my tests |
I initially reported as #1397 ; I noted that the checkbox behavior is implemented by doing an PointerEvent should be a subclass of MouseEvent, and that check should check for instances of MouseEvent |
Thank you for reporting @VividLemon, @dbritto-dev and @cyyynthia! 🙂 There is a fix in now: |
Describe the bug
A clear and concise description of what the bug is.
During a change from v13 to v14, I noticed that my tests had randomly broke. I assumed it was something internally, but when regressing back my package.json, everything worked fine. I pushed each version one by one until I found it was v14 of happy dom.
To Reproduce
I have the two following components:
child:
parent:
When done rawly in the browser (firefox)
document.getElementById('foo').click()
I getmodelvalue change false
This is correct.However, when I go to my test:
This should not be failing.
What's perplexing is that in my example reproduction, I don't get anything in the test. All versions seem to fail... Unlike the main repository just failing between those two versions:
vue-project.zip
As said, in my real repository, I'm only seeing the issue when going between
13.6.2->13.7.0
at https:/bootstrap-vue-next/bootstrap-vue-next/blob/6ea759874fd41d3da08ae3cafee052e19b3e51e1/packages/bootstrap-vue-next/src/components/BFormCheckbox/form-checkbox.spec.ts#L600It may be more useful to pull that repository, and view the issue there. For now, I'm going to keep the happy-dom version on 13.6.2. The issue exists in v14 latest
Expected behavior
A clear and concise description of what you expected to happen.
The emitted() return should have
update:modelValue
as a key in the object -- it should not be undefined, and the test should pass.Screenshots
If applicable, add screenshots to help explain your problem.
v13.6.2
v13.7.0
Device:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: