Skip to content

Commit

Permalink
Fix filter step reference (#2273)
Browse files Browse the repository at this point in the history
* Fix filter step reference

* pipe
  • Loading branch information
jonmeow authored Oct 13, 2022
1 parent b374595 commit 418b28d
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/assign_prs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
assign_reviewer:
runs-on: ubuntu-latest
steps:
- id: path-filter
- id: filter
uses: dorny/paths-filter@v2
with:
filters: |
Expand All @@ -29,31 +29,31 @@ jobs:
- 'toolchain/**'
- id: assign-leads
if: steps.changes.outputs.leads == 'true'
if: steps.filter.outputs.leads == 'true'
uses: hkusu/[email protected]
with:
reviewers: KateGregory, chandlerc, zygoloid
max-num-of-reviewers: 1

- id: assign-explorer
if: steps.changes.outputs.explorer == 'true'
if: steps.filter.outputs.explorer == 'true'
uses: hkusu/[email protected]
with:
reviewers: geoffromer, jonmeow, jsiek, zygoloid
reviewers: geoffromer, jonmeow, zygoloid
max-num-of-reviewers: 1

- id: assign-toolchain
if: steps.changes.outputs.toolchain == 'true'
if: steps.filter.outputs.toolchain == 'true'
uses: hkusu/[email protected]
with:
reviewers: chandlerc, jonmeow, zygoloid
max-num-of-reviewers: 1

- id: assign-fallback
if:
steps.changes.outputs.leads != 'true' &&
steps.changes.outputs.explorer != 'true' &&
steps.changes.outputs.toolchain != 'true'
if: |
steps.filter.outputs.leads != 'true' &&
steps.filter.outputs.explorer != 'true' &&
steps.filter.outputs.toolchain != 'true'
uses: hkusu/[email protected]
with:
reviewers: chandlerc, jonmeow, josh11b, zygoloid
Expand Down

1 comment on commit 418b28d

@zygoloid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, detailed commit message should have been:

I noticed #2265 got assigned to me, I think the mismatch is why (apparently the comparison fails silently, and the pools have enough similarity it escaped my notice).

Also removing jsiek from the explorer review list since I think he's not interested in picking up reviews.

... but I accidentally hit the merge button in github too soon.

Please sign in to comment.