-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design overview update part 2 #1325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM.
Some generally minor suggestions/comments inline. If the suggestions work, feel free to merge. At least one of them is a bit interesting though, so happy to follow-up if you'd like to try a different approach.
docs/design/README.md
Outdated
#### Name lookup for common types | ||
|
||
FIXME: should this be renamed to "The prelude"? | ||
> **TODO:** should this be renamed to "The prelude"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we include the keywords, probably not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted.
Co-authored-by: Chandler Carruth <[email protected]>
This follows #1274 and #1325 and fills in the "safety" section. It only covers our approach in general terms. Co-authored-by: Chandler Carruth <[email protected]>
This follows #1274 , #1325 , and #1328 . It fills in the "Bidirectional interoperability with C and C++" section. Co-authored-by: Chandler Carruth <[email protected]> Co-authored-by: Geoff Romer <[email protected]>
This follows #1274 . It mainly fills in the "generics" section, with smaller updates to other section. Co-authored-by: Chandler Carruth <[email protected]>
This follows #1274 and #1325 and fills in the "safety" section. It only covers our approach in general terms. Co-authored-by: Chandler Carruth <[email protected]>
This follows #1274 , #1325 , and #1328 . It fills in the "Bidirectional interoperability with C and C++" section. Co-authored-by: Chandler Carruth <[email protected]> Co-authored-by: Geoff Romer <[email protected]>
This follows #1274 , #1325 , #1328 , and #1336 . It fills in the "Names" section. Co-authored-by: Richard Smith <[email protected]> Co-authored-by: Chandler Carruth <[email protected]>
This follows #1274 , #1325 , #1328 , #1336 , #1347 , and #1368 . This fills in details about how values work, value categories, parameter passing, unformed state, and so on. Co-authored-by: Geoff Romer <[email protected]> Co-authored-by: Richard Smith <[email protected]> Co-authored-by: Chandler Carruth <[email protected]>
This follows #1274 . It mainly fills in the "generics" section, with smaller updates to other section.