Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primitive types #1975

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Primitive types #1975

merged 5 commits into from
Sep 9, 2022

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Aug 10, 2022 •
edited
Loading

A few changes:

  • Merge content from the primitive_types.md design doc into the overall design README.md since there was so much overlap and no need for two copies.
  • Consistently spell integer types Carbon.Int(N) and Carbon.UInt(N), including the Carbon. prefix and avoiding Unsigned(N).
  • Consistently use a comprehensive set of floating-point types.
  • Incorporates Numeric type literal syntax #2015 into the design docs.

jonmeow
jonmeow reviewed Aug 10, 2022
View reviewed changes
docs/design/README.md Outdated Show resolved Hide resolved
chandlerc
chandlerc reviewed Aug 10, 2022
View reviewed changes
docs/design/expressions/implicit_conversions.md Outdated Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
josh11b added a commit to josh11b/carbon-lang that referenced this pull request Aug 10, 2022
@josh11b
Undo changes made separately in carbon-language#1975
35b8674
This was referenced Aug 16, 2022
Open
Merged
josh11b
josh11b commented Aug 30, 2022
View reviewed changes
Copy link
Contributor Author

@josh11b josh11b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be ready as soon as #2015 is merged.

docs/design/expressions/implicit_conversions.md Outdated Show resolved Hide resolved
docs/design/expressions/implicit_conversions.md Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
@josh11b josh11b merged commit 14206da into carbon-language:trunk Sep 9, 2022
@cguiubg cguiubg mentioned this pull request Oct 15, 2022
Closed
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
@josh11b josh11b deleted the conv branch September 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc left review comments

@jonmeow jonmeow jonmeow left review comments

@geoffromer geoffromer geoffromer approved these changes

Assignees
No one assigned
Labels
documentation An issue or proposed change to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josh11b @chandlerc @geoffromer @jonmeow