Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate the addition of RUN and simplify RUN lines #2292

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Automate the addition of RUN and simplify RUN lines #2292

merged 3 commits into from
Oct 17, 2022

Conversation

jonmeow
Copy link
Contributor

@jonmeow jonmeow commented Oct 14, 2022

This was an offshoot of the discussion about how much boilerplate we could remove. lit requires RUN lines be there, everything else is optional.

@jonmeow jonmeow requested a review from zygoloid October 14, 2022 23:31
zygoloid
zygoloid approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we also do a mass-replacement of // AUTOUPDATE: ... lines with just // AUTOUPDATE?

@zygoloid
Copy link
Contributor

zygoloid commented Oct 15, 2022 •
edited
Loading

Is the description correct? It looks like the script requires the AUTOUPDATE line to be present, but everything else, including RUN lines, is now optional and can be recreated by the script.

@jonmeow
Copy link
Contributor Author

jonmeow commented Oct 17, 2022

Is the description correct? It looks like the script requires the AUTOUPDATE line to be present, but everything else, including RUN lines, is now optional and can be recreated by the script.

I think so? "lit requires RUN lines be there, everything else is optional." -- Maybe the confusion here is lit versus lit_autodupate.py? lit requires the RUN lines, lit_autoupdate.py does not.

@jonmeow
Copy link
Contributor Author

jonmeow commented Oct 17, 2022

Looks good. Should we also do a mass-replacement of // AUTOUPDATE: ... lines with just // AUTOUPDATE?

Whoops, forgot to do that. Doing it now.

@jonmeow jonmeow merged commit eac7c2b into carbon-language:trunk Oct 17, 2022
@jonmeow jonmeow deleted the lit-simple branch October 17, 2022 20:52
zygoloid added a commit to zygoloid/carbon-lang that referenced this pull request Oct 18, 2022
@zygoloid
Fix test failures caused by interaction between carbon-language#2294 …
9b2a73f 
…and carbon-language#2292.
jonmeow pushed a commit that referenced this pull request Oct 18, 2022
@zygoloid
Fix test failures caused by interaction between #2294 and #2292. (#2303)
fa18cc0
@chandlerc chandlerc added the explorer Action items related to Carbon explorer code label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zygoloid zygoloid zygoloid approved these changes

@geoffromer geoffromer Awaiting requested review from geoffromer

@chandlerc chandlerc Awaiting requested review from chandlerc

Assignees
No one assigned
Labels
explorer Action items related to Carbon explorer code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonmeow @zygoloid @chandlerc