Expand handling of function redeclarations. #3739
Conversation
jonmeow
force-pushed
the
fn-redecl
branch
2 times, most recently
from
848f3db
to
55edf85
Compare
toolchain/check/function.cpp
Outdated
| } | ||
|
|
||
| // Returns true if two param refs agree. | ||
| static auto DoParamAgrees(Context& context, SemIR::InstId new_decl_id, |
There was a problem hiding this comment.
| static auto DoParamAgrees(Context& context, SemIR::InstId new_decl_id, | |
| static auto DoParamsAgree(Context& context, SemIR::InstId new_decl_id, |
I think? (I'd read "DoParamAgrees" as "do the 'param-agrees' process", which might be accurate but seems a bit awkward.)
But given that this is producing diagnostics rather than just computing a bool, I think naming this so it doesn't sound like a predicate might be better. Maybe:
| static auto DoParamAgrees(Context& context, SemIR::InstId new_decl_id, | |
| static auto CheckParamsAgree(Context& context, SemIR::InstId new_decl_id, |
There was a problem hiding this comment.
This was some sloppy naming, but how about just CheckRedecl + Param + s as naming. :)
There was a problem hiding this comment.
That name works for me, but I think it'd be better to have more difference between the names of CheckRedeclParams and CheckRedeclParam to reflect that one of them is producing diagnostics and the other is just performing a comparison. (Or maybe make them both produce diagnostics per the FIXME.)
There was a problem hiding this comment.
Moved (not really addressing the FIXME, I don't think the structure is worth addressing)
jonmeow
force-pushed
the
fn-redecl
branch
2 times, most recently
from
d4f89ac
to
fac1185
Compare
This detects more cases of incorrect matches between declaration and definition. It also factors the logic out to a separate file for easier sharing, particularly when it comes to merging imports (I'm not sure if this exact API will be reshared, but the core logic should apply).