Skip to content

Commit

Permalink
Mark LoggingSpec pending on macOS
Browse files Browse the repository at this point in the history
This might help reduce the unit test timeouts on macOS hydra builds.

Investigating #2472 Jonathan found the following tests to fail with limited ulimit -v:
    36% Match String: "Checkpoint"
    44% Match String: "correct time measures"
   100% Match String: "different request ids"
    20% Match String: "Private Key"
    32% Match String: "Tx History"
    28% Match String: "Wallet Metadata"

where entries 2 and 3 are from LogginsSpec.

The timeouts in CI were in these following locations:

  12 times (28%) 000000 // from "Not Allowed Methods"
  9 times (21%) Checkpoint
  8 times (19%) rollback
  5 times (12%) 8601 // from e.g. "ISO 8601 extended format without timezones"
  4 times (9%) JSON
  4 times (9%) MVar
  4 times (9%) readStakeDistribution // only in the past, so now fixed
  1 times (2%) Coverage

which either suggest there are an 10+ lines of output not shown in the
output, or the LoggingSpec isn't to blame.

So it would be very interesting to see whether this commit reduces
timeouts or not.
  • Loading branch information
Anviking committed Jun 14, 2021
1 parent e629dcf commit 127d785
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/core/test/unit/Network/Wai/Middleware/LoggingSpec.hs
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ import Test.QuickCheck
( Arbitrary (..), choose, counterexample, property, withMaxSuccess )
import Test.QuickCheck.Monadic
( assert, monadicIO, monitor )
import Test.Utils.Darwin
( pendingOnMacOS )
import UnliftIO.Async
( Async, async, cancel, mapConcurrently, replicateConcurrently_ )
import UnliftIO.Concurrent
Expand All @@ -113,7 +115,9 @@ import qualified Data.Text as T
import qualified Network.Wai.Handler.Warp as Warp

spec :: Spec
spec = describe "Logging Middleware" $ do
spec = before (pendingOnMacOS "#2472 regular timeouts in macOS hydra builds")
$ describe "Logging Middleware" $ do

before setup $ after tearDown $ do
it "GET, 200, no query" $ \ctx -> do
get ctx "/get"
Expand Down

0 comments on commit 127d785

Please sign in to comment.