Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local-cluster metadata-server FILE command for testing #2511

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Feb 11, 2021

Issue Number

Overview

  • Add mock-token-metadata-server FILE tool for testing
  • Make mock server re-read the json file on each request, to allow re-loading

Comments

This way you can edit the file, and have it be reloaded automatically.
@Anviking Anviking force-pushed the anviking/ADP-688/mock-meta-source-2 branch 2 times, most recently from d480aa4 to 885b882 Compare February 11, 2021 16:17
@@ -122,11 +122,20 @@
(hsPkgs."directory" or (errorHandler.buildDepError "directory"))
(hsPkgs."filepath" or (errorHandler.buildDepError "filepath"))
(hsPkgs."lobemo-backend-ekg" or (errorHandler.buildDepError "lobemo-backend-ekg"))
(hsPkgs."optparse-applicative" or (errorHandler.buildDepError "optparse-applicative"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now unnecessary I assume?

Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Anviking Anviking force-pushed the anviking/ADP-688/mock-meta-source-2 branch from 885b882 to a47a10d Compare February 11, 2021 16:41
@Anviking
Copy link
Member Author

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 11, 2021
2511: Add `local-cluster metadata-server FILE` command for testing r=Anviking a=Anviking

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

- [x] Add `local-cluster metadata-server FILE` command for testing
- [x] Make mock server re-read the json file on each request, to allow re-loading 


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: IOHK <[email protected]>
@Anviking Anviking self-assigned this Feb 11, 2021
@Anviking Anviking force-pushed the anviking/ADP-688/mock-meta-source-2 branch from 7a4ba48 to 9d9b0d6 Compare February 11, 2021 17:17
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 11, 2021

Canceled.

@Anviking
Copy link
Member Author

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 11, 2021
2511: Add `local-cluster metadata-server FILE` command for testing r=Anviking a=Anviking

# Issue Number

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->


# Overview

- [x] Add `local-cluster metadata-server FILE` command for testing
- [x] Make mock server re-read the json file on each request, to allow re-loading 


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 11, 2021

Build failed:

#2217

@KtorZ
Copy link
Member

KtorZ commented Feb 11, 2021

bors retry

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 11, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 475384a into master Feb 11, 2021
@iohk-bors iohk-bors bot deleted the anviking/ADP-688/mock-meta-source-2 branch February 11, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants