Add fingerprint to assets (cf: CIP-0014) #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation, design and rationale explained in: cardano-foundation/CIPs#64
KtorZ
changed the title
KtorZ
changed the title
Anviking
approved these changes
Feb 11, 2021
| toText = unTokenFingerprint | ||
|
|
||
| instance FromText TokenFingerprint where | ||
| fromText txt = case Bech32.decodeLenient txt of |
There was a problem hiding this comment.
We could add a textRoundtrip test I take?
|
That said, it's arguably a bit complicated that:
|
Isn't it? But there isn't much we can do about it unfortunately. |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 11, 2021
2512: Add fingerprint to assets (cf: CIP-0014) r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. --> # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> Motivation, design and rationale explained in: [CIP-0014](cardano-foundation/CIPs#64) # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: KtorZ <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-703
Overview
Motivation, design and rationale explained in: CIP-0014
Comments