Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test.Utils.Pretty and verifyMsg #2724

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Add Test.Utils.Pretty and verifyMsg #2724

merged 4 commits into from
Jun 21, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jun 18, 2021

Issue Number

ADP-970

Overview

  • Add a more descriptive verifyMsg function to the integration tests.
  • Move the Pretty helper newtype into Test.Utils.Pretty.

Comments

This code was rescued from #2708.

@rvl rvl requested a review from Anviking June 18, 2021 03:54
@rvl rvl self-assigned this Jun 18, 2021
jonathanknowles
jonathanknowles approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@jonathanknowles jonathanknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Just a minor suggestion.

lib/core-integration/src/Test/Integration/Framework/DSL.hs Outdated

-- | Applies the value 'a' to all assertions in the given sequence.
--
-- Like 'verify', but the counterexample shows a description of what conditions were being checked.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- Like 'verify', but the counterexample shows a description of what conditions were being checked.
-- Like 'verify', but the counterexample shows a description of what conditions
-- were being checked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

@rvl rvl force-pushed the rvl/adp-970/fmt-pretty-tests branch 2 times, most recently from 606387e to 52c1a71 Compare June 18, 2021 11:07
@Anviking Anviking force-pushed the rvl/adp-970/fmt-pretty-tests branch from c474da1 to 0830bbc Compare June 18, 2021 12:47
@Anviking Anviking force-pushed the rvl/adp-970/fmt-pretty-tests branch from 0830bbc to f095510 Compare June 18, 2021 13:02
@Anviking
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 18, 2021
@iohk-bors @rvl
Merge #2724
8bde5fb 
2724: Add Test.Utils.Pretty and verifyMsg r=Anviking a=rvl

### Issue Number

ADP-970

### Overview

- Add a more descriptive `verifyMsg` function to the integration tests.
- Move the `Pretty` helper newtype into `Test.Utils.Pretty`.

### Comments

This code was rescued from #2708.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 18, 2021 •
edited by Anviking
Loading

Build failed:

#2472
Timed out in the State Machine Tests:

shrinker for PutDelegationCertificate
      Generator for IsStakeKeyRegistered
      Shrinker for IsStakeKeyRegistered
      Generator for PutTxHistory
      Shrinker for PutTxHistory
      Generator for ReadTxHistory
      Shrinker for ReadTxHistory
      Generator for ReadLocalTxSubmissionPending
      Shrinker for ReadLocalTxSubmissionPending
      Generator for UpdatePendingTxForExpiry
      Shrinker for UpdatePendingTxForExpiry
      Generator for RemovePendingOrExpiredTx
      Shrinker for RemovePendingOrExpiredTx
      Generator for PutPrivateKey
      Shrinker for PutPrivateKey
      Generator for ReadPrivateKey
      Shrinker for ReadPrivateKey
      Generator for RollbackTo
      Shrinker for RollbackTo
      Generator for ReadGenesisParameters
      Shrinker for ReadGenesisParameters
building of '/nix/store/s0kh86w1sqgqg3n8jifnmqirb7jvlapp-cardano-wallet-core-test-unit-2021.6.11-check' timed out after 900 seconds of silence

Timed out in the integration tests:
#2540

    TRANS_CREATE_04 - Wrong password
    TRANS_CREATE_07 - Deleted wallet
    TRANS_CREATE_08 - Bad payload
      empty payload
      {} payload
      non-json valid payload
[cardano-wallet.api-server:Warning:19066] [2021-06-18 15:09:59.33 UTC] [RequestId 1950] POST /v2/wallets 201 Created in 1.878561s
    TRANS_ASSETS_CREATE_01 - Multi-asset balance
[cardano-wallet.api-server:Warning:2324] [2021-06-18 15:10:03.91 UTC] [RequestId 1977] POST /v2/wallets 201 Created in 1.010059s
[cardano-wallet.api-server:Warning:19066] [2021-06-18 15:10:04.06 UTC] [RequestId 1978] POST /v2/wallets 201 Created in 1.023109s
    TRANS_ASSETS_CREATE_01a - Multi-asset transaction with Ada
    TRANS_ASSETS_CREATE_02 - Multi-asset transaction with small Ada amount
    TRANS_ASSETS_CREATE_02a - Multi-asset transaction without Ada
[cardano-wallet.api-server:Warning:2322] [2021-06-18 15:10:08.73 UTC] [RequestId 2003] POST /v2/wallets/e6df400846dcefe23edf2d7cc71c40015c62e9f1/transactions 202 Accepted in 1.458018s
building of '/nix/store/p9qia0840b0dnc85skz4q7iqwqr4rnmg-cardano-wallet-test-integration-2021.6.11-check' timed out after 900 seconds of silence

@Anviking
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 21, 2021
@iohk-bors @rvl
Merge #2724
5ff75c2 
2724: Add Test.Utils.Pretty and verifyMsg r=Anviking a=rvl

### Issue Number

ADP-970

### Overview

- Add a more descriptive `verifyMsg` function to the integration tests.
- Move the `Pretty` helper newtype into `Test.Utils.Pretty`.

### Comments

This code was rescued from #2708.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 21, 2021 •
edited by Anviking
Loading

Build failed:

cardano-wallet                 >   src/Test/Integration/Scenario/CLI/Shelley/Transactions.hs:387:59:
--
  | cardano-wallet                 >   1) CLI Specifications, SHELLEY_CLI_TRANSACTIONS, TRANS_ESTIMATE_09 - Invalid amount, -1000
  | cardano-wallet                 >        uncaught exception: IOException of type ResourceVanished
  | cardano-wallet                 >        fd:134: hFlush: resource vanished (Broken pipe)
  | cardano-wallet                 >

#2753 (similar, though different test)

@Anviking
Copy link
Member

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 21, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit fe50727 into master Jun 21, 2021
@iohk-bors iohk-bors bot deleted the rvl/adp-970/fmt-pretty-tests branch June 21, 2021 21:26
@Anviking Anviking mentioned this pull request Jun 22, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking left review comments

@jonathanknowles jonathanknowles jonathanknowles approved these changes

Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvl @Anviking @jonathanknowles