Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require more recent version of hspec (>= 2.8.2). #2726

Merged
merged 8 commits into from
Jun 23, 2021

Conversation

jonathanknowles
Copy link
Member

Issue Number

ADP-978

Overview

This PR upgrades hspec to a more recent version that supports the following options:

  • --times prints an execution time for each individual spec.
  • --print-slow-items[=n] prints the n slowest spec items at the end of a test run.

@rvl rvl force-pushed the jonathanknowles/upgrade-hspec branch from 1f239c8 to fce6720 Compare June 18, 2021 10:56
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

@rvl
Copy link
Contributor

rvl commented Jun 18, 2021

That version of hspec will require an index-state update.
We may as well bump Haskell.nix for that.

@jonathanknowles
Copy link
Member Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 21, 2021
2726: Require more recent version of `hspec` (>= 2.8.2). r=jonathanknowles a=jonathanknowles

# Issue Number

ADP-978

# Overview

This PR upgrades `hspec` to a more recent version that supports the following options:

* `--times` prints an execution time for each individual spec.
* `--print-slow-items[=n]` prints the `n` slowest spec items at the end of a test run.

Co-authored-by: Jonathan Knowles <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 21, 2021

Build failed:

#expected

@rvl rvl force-pushed the jonathanknowles/upgrade-hspec branch from fce6720 to 9df941a Compare June 21, 2021 12:03
@rvl rvl force-pushed the jonathanknowles/upgrade-hspec branch from 18f158c to 831eb0f Compare June 22, 2021 03:14
rvl added 3 commits June 22, 2021 14:49
... to fix a build error.
Version 1.0.0.0 started failing with the new Haskell.nix rev, because
previous cabal.project build fixes were removed.
@rvl rvl force-pushed the jonathanknowles/upgrade-hspec branch from 097b206 to 96c29ec Compare June 22, 2021 04:49
@rvl
Copy link
Contributor

rvl commented Jun 23, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 23, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit c879f44 into master Jun 23, 2021
@iohk-bors iohk-bors bot deleted the jonathanknowles/upgrade-hspec branch June 23, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants