Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the cabal build #2748

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Fix the cabal build #2748

merged 3 commits into from
Jul 1, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jul 1, 2021 •
edited
Loading

Issue Number

#2742

Overview

  • Add a cabal constraint to avoid incompatible new versions of persistent.
  • Add a cabal constraint to avoid incompatible new versions of openapi3.

Comments

Buildkite pipeline link

@rvl
Cabal: Add version constraints on persistent
1d61104 
The cabal build was failing due to:

    src/Cardano/Pool/DB/Sqlite/TH.hs:50:7: error: [-Wdeprecations, -Werror=deprecations]
    In the use of ‘mkDeleteCascade’
    (imported from Database.Persist.TH):
    Deprecated: "You can now set update and delete cascade behavior directly on the entity in the quasiquoter. This function and class are deprecated and will be removed in the next major ersion."
    \|
    50 \|     , mkDeleteCascade sqlSettings'
    \|       ^^^^^^^^^^^^^^^
    cabal: Failed to build cardano-wallet-core-2021.6.11 (which is required by
    bench:restore from cardano-wallet-2021.6.11, exe:local-cluster from
    cardano-wallet-2021.6.11 and others).

We will need to adjust our code to work with newer versions of
persistent, once we update to Stackage LTS 18.*.

Resolves #2742
@rvl rvl added the Bug label Jul 1, 2021
@rvl rvl requested a review from piotr-iohk July 1, 2021 03:32
@rvl rvl self-assigned this Jul 1, 2021
@rvl rvl linked an issue Jul 1, 2021 that may be closed by this pull request
Cabal build fails in CI #2742
Closed
@rvl rvl added the Test failure A flaky test or nightly CI failure label Jul 1, 2021
piotr-iohk
piotr-iohk approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@rvl
Copy link
Contributor Author

rvl commented Jul 1, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 1, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 9a3b6bb into master Jul 1, 2021
@iohk-bors iohk-bors bot deleted the rvl/2742/fix-cabal branch July 1, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

Assignees

@rvl rvl

Labels
Bug Test failure A flaky test or nightly CI failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cabal build fails in CI
2 participants
@rvl @piotr-iohk