Negotiate NodeToClientVersion for non-breaking mainnet support #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
approved these changes
Aug 1, 2021
Anviking
force-pushed
the
anviking/adp-1025/negotiate-version
branch
2 times, most recently
from
31fa627
to
5dba8cd
Compare
On Mary, nothing we do should require V_9. Even Frankly, I'm not sure exactly what needs
So I'd suspect |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 2, 2021
2791: Negotiate NodeToClientVersion for non-breaking mainnet support r=Anviking a=Anviking # Issue Number ADP-1025 # Background #2763 made the wallet demand NodeToClientV_9. With cardano-node 1.28.0, V_9 is only enabled if `TestEnableDevelopmentNetworkProtocols` is set in the node config. # Overview - [x] Make the wallet support both `V_8` and `V_9`. - [x] Ensure integration tests on Mary are run without `TestEnableDevelopmentNetworkProtocols: True` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <[email protected]>
Anviking
force-pushed
the
anviking/adp-1025/negotiate-version
branch
from
5dba8cd
to
d99407b
Compare
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 2, 2021
2791: Negotiate NodeToClientVersion for non-breaking mainnet support r=Anviking a=Anviking # Issue Number ADP-1025 # Background #2763 made the wallet demand NodeToClientV_9. With cardano-node 1.28.0, V_9 is only enabled if `TestEnableDevelopmentNetworkProtocols` is set in the node config. # Overview - [x] Make the wallet support both `V_8` and `V_9`. - [x] Ensure integration tests on Mary are run without `TestEnableDevelopmentNetworkProtocols: True` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <[email protected]>
|
Build failed: #expected (weeder) |
Anviking
force-pushed
the
anviking/adp-1025/negotiate-version
branch
2 times, most recently
from
30360ad
to
10c0573
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 2, 2021
2791: Negotiate NodeToClientVersion for non-breaking mainnet support r=Anviking a=Anviking # Issue Number ADP-1025 # Background #2763 made the wallet demand NodeToClientV_9. With cardano-node 1.28.0, V_9 is only enabled if `TestEnableDevelopmentNetworkProtocols` is set in the node config. # Overview - [x] Make the wallet support both `V_8` and `V_9`. - [x] Ensure integration tests on Mary are run without `TestEnableDevelopmentNetworkProtocols: True` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <[email protected]>
Anviking
force-pushed
the
anviking/adp-1025/negotiate-version
branch
from
10c0573
to
1342308
Compare
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 2, 2021
2791: Negotiate NodeToClientVersion for non-breaking mainnet support r=Anviking a=Anviking # Issue Number ADP-1025 # Background #2763 made the wallet demand NodeToClientV_9. With cardano-node 1.28.0, V_9 is only enabled if `TestEnableDevelopmentNetworkProtocols` is set in the node config. # Overview - [x] Make the wallet support both `V_8` and `V_9`. - [x] Ensure integration tests on Mary are run without `TestEnableDevelopmentNetworkProtocols: True` # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <[email protected]>
1. Make Ouroboros applications not hard-code the version 2. Pass in both V_8 and V_9 3. Only parse the NetworkMagic from genesis, not the NodeToClientVersion. This seemed unused anyway.
Instead of always setting TestEnableDevelopmentNetworkProtocols in the
integration tests, with this commit we only set it if the era is Alonzo.
Because we run the integration tests on Mary in buildkite, this should
mean that the wallet now again works with mainnet nodes, without
TestEnableDevelopmentNetworkProtocols.
Haven't actually tested to connect against mainnet. But I did sanity
check that we got
"eras": {
"shelley": {
"epoch_start_time": "2021-07-31T19:10:38Z",
"epoch_number": 0
},
"mary": {
"epoch_start_time": "2021-07-31T19:10:38Z",
"epoch_number": 0
},
"byron": {
"epoch_start_time": "2021-07-31T19:10:38Z",
"epoch_number": 0
},
"allegra": {
"epoch_start_time": "2021-07-31T19:10:38Z",
"epoch_number": 0
},
"alonzo": null
from GET /network/parameters
when running `LOCAL_CLUSTER_ERA=mary NO_POOLS=1 NO_CLEANUP=1 local-cluster`
and that TestEnableDevelopmentNetworkProtocols was absent from the BFT
node's config.
Anviking
force-pushed
the
anviking/adp-1025/negotiate-version
branch
from
1342308
to
02f1c32
Compare
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1025
Background
#2763 made the wallet demand NodeToClientV_9. With cardano-node 1.28.0, V_9 is only enabled if
TestEnableDevelopmentNetworkProtocolsis set in the node config.Overview
V_8andV_9.TestEnableDevelopmentNetworkProtocols: TrueComments