Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts/gh/show-bump.sh run in nix #2820

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

Anviking
Copy link
Member

  • Make scripts/gh/show-bump.sh run in nix-shell, such that you don't need to worry about installing dependencies manually.

Issue Number

None / Release.

Comments

@Anviking Anviking self-assigned this Aug 12, 2021
@Anviking Anviking requested a review from rvl August 12, 2021 13:27
@Anviking
Copy link
Member Author

Not sure why it fails with

In ./scripts/gh/show-bump.sh line 1:
--
  | #! /usr/bin/env nix-shell
  | ^-- SC1008: This shebang was unrecognized. ShellCheck only supports sh/bash/dash/ksh. Add a 'shell' directive to specify.

while nix-shell is fine in make_release.sh

Anviking and others added 2 commits August 16, 2021 16:24
Such that everyone can run it without installing the deps manually.
Better to let the user select their auth preferences with ~/.jira.d.
@rvl rvl force-pushed the anviking/release-process-improvements branch from 61935df to db64218 Compare August 16, 2021 08:25
@rvl
Copy link
Contributor

rvl commented Aug 16, 2021

If not using a standard shell script interpreter like #!/bin/sh, then shellcheck needs to be told which kind of shell with a directive. I fixed it.

Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rvl rvl merged commit 222bd99 into master Aug 16, 2021
@rvl rvl deleted the anviking/release-process-improvements branch August 16, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants