Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose to support testnet and alonzo-purple #2826

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

piotr-iohk
Copy link
Contributor

  • Fix docker-compose to support testnet and alonzo-purple

Issue Number

ADP-1068 / #2806

Comments

docker-compose should now work for mainnet, testnet or alonzo-purple:

NETWORK=alonzo-purple docker-compose up
NETWORK=mainnet docker-compose up
NETWORK=testnet docker-compose up

@piotr-iohk piotr-iohk added the Bug label Aug 16, 2021
@piotr-iohk piotr-iohk self-assigned this Aug 16, 2021
@piotr-iohk piotr-iohk requested a review from rvl August 16, 2021 14:27
@piotr-iohk piotr-iohk linked an issue Aug 16, 2021 that may be closed by this pull request
Comment on lines +31 to +32
([[ $$NETWORK == \"alonzo-purple\" ]] && $$CMD --testnet /config/y88z6z1w0kwypj7zrlhk7vs6z8k1pckd-byron-genesis.json) ||
($$CMD --testnet /config/kax0css4lx3ywihvsgrqjym0jpi20f99-byron-genesis.json)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very fragile because the hashes will change.

We really need the cardano-node docker image to provide an organised /config directory, like the one I have added into our docker image (new commits on this branch).

Copy link
Contributor Author

@piotr-iohk piotr-iohk Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, how about we use config files from the cardano-wallet /config directory then? (done in 50c19e8)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that would be good for the next release. But if anyone uses docker-compose.yml from master branch, there will be no /config/${NETWORK} in the inputoutput/cardano-wallet:2021.8.11 image.

So perhaps we could use fragile nix store path hashes until the day of next release, then merge 50c19e8 with the release bump PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've added temp note to https:/input-output-hk/cardano-wallet/wiki/Release-Checklist so we don't forget.

@rvl rvl force-pushed the piotr/ADP-1068/fix-docker-compose branch from 50c19e8 to bedb827 Compare August 18, 2021 05:05
@rvl rvl merged commit fa8556d into master Aug 18, 2021
@rvl rvl deleted the piotr/ADP-1068/fix-docker-compose branch August 18, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot start API server using docker-compose on NETWORK=testnet
2 participants