Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3388] Add configs to docker image #4685

Merged
merged 5 commits into from
Jul 17, 2024
Merged

[ADP-3388] Add configs to docker image #4685

merged 5 commits into from
Jul 17, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jul 17, 2024 •
edited
Loading

  • Include the node configs in the docker image
  • Use the included configs in docker compose

ADP-3388

@paolino paolino force-pushed the paolino/ADP-3388/add-configs-to-docker-image branch from 325fc16 to ac6d475 Compare July 17, 2024 10:22
@HeinrichApfelmus HeinrichApfelmus force-pushed the paolino/ADP-3388/add-configs-to-docker-image branch 5 times, most recently from 8d72811 to f988b58 Compare July 17, 2024 12:00
@paolino paolino force-pushed the paolino/ADP-3388/add-configs-to-docker-image branch from f988b58 to b22b2a5 Compare July 17, 2024 14:52
@paolino paolino force-pushed the paolino/ADP-3388/add-configs-to-docker-image branch from b22b2a5 to 8827dd5 Compare July 17, 2024 14:52
@paolino paolino changed the base branch from test-rc/paolino/ADP-3387/update-node-configurations to master July 17, 2024 14:54
@paolino paolino self-assigned this Jul 17, 2024
@paolino paolino added CI CI related Release labels Jul 17, 2024
@paolino paolino marked this pull request as ready for review July 17, 2024 14:55
HeinrichApfelmus
HeinrichApfelmus approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! 😊

@paolino paolino enabled auto-merge July 17, 2024 15:23
@paolino paolino added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit 9f29038 Jul 17, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3388/add-configs-to-docker-image branch July 17, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
CI CI related Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus