Cover art support 2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
cardinot
commented
Jul 10, 2014
cardinot
commented
- redesign dlgtrackinfo to show covers
- load cover in dlgtrackinfo
- edit cover location in dlgtrackinfo
- unset cover (load default)
- reload cover from metadata
- warning box issue
- icon for each cover_art action
- copy cover from external dir to track dir (if the user changes the cover)
- The current layout of dlgtrackinfo is not good, because it has not a size compatible with small screens (netbooks).
…nto coverArtSupport_2
- It needs more work. - dlgtrackinfo must handle the cover size and always display them with the same size (scaling).
…nto coverArtSupport_2
In this way we would be loading it just once and all widgets would get it from CoverArtCache
we are drawing the pixmap in a QIcon and as it has a fixed size, it's not necessary rescaling pixmaps
…he cover (needs more work)
- after that, future requestPixmaps will do the "searching step". Should we handle it and avoid doing searchs after a purge?
…of searchEmbeddedCover()
Handling cases when: - embedded cover is different from de current cover (ask if want to change) - current cover is not NULL but embedded cover is NULL (ask if want to remove)
…e cover_art placeholder
… YEAR KEY TRACK based on jus suggestion
…anna change the cover)
…oupbox + increase cover size
…nto coverArtSupport_2
…nto coverArtSupport_2
…nto coverArtSupport_2
…"reload" As it is using the search algorithm - it will try to reload the cover as normally we do (firstly looking in the id3tag and then in the trackdir)
…ack metadata from file" When an user clicks on "reload track metadata from file", Mixxx must not touch the cover art
- as all fields are always overwritten when the user choose "reload" them, it did not make sense having warning boxes (to warn about cases of overwriting) just for covers...
…ctory This is important because the user could choose an image from a removable disk or any another place which could not be available in a “near future”. So, it is much more safe let it together with the track. It is also good because the user could reuse the cover in other software (automatic)…
cardinot
pushed a commit
that referenced
this pull request
Jul 21, 2014
replace memmove with direct assignments, saves ~ 10 % CPU time
…nto coverArtSupport_2
…over_art on the right side - It is very important that all fields have the same vertical spacing. I noticed that the only way to ensure it is drawing all fields in the same box_layout...
…utton - the qpushbutton will rescale just covers which are bigger than the icon bounds, so it is important rescale all of then to ensure that it will always use as much space as possible...
…nto coverArtSupport_2 Conflicts: src/dlgtrackinfo.ui
…nto coverArtSupport_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.