Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create GH Actions to inset version number in footer of template? #493

Open
fmichonneau opened this issue Aug 14, 2020 · 2 comments
Open

Comments

@fmichonneau
Copy link
Contributor

The footer of the template includes "Using The Carpentries style version 9.5.3." (it has been the same version number for a long time...)

The version number is hard-coded, and we continuously bring improvements to the template, which is not very suitable for a release-based versioning system.

I'm wondering if we could use a GitHub Actions workflow to insert into the footer the (short) sha1 from the latest commit (or something else) to identify the version number. This could possibly be done with a variable (stored in _config.yml or _data/version.yml for instance).

One of the drawbacks is that it would create a lot of noise in the commit history.

@maxim-belkin
Copy link
Contributor

I'm wondering if we could use a GitHub Actions workflow to insert into the footer the (short) sha1 from the latest commit (or something else) to identify the version number. This could possibly be done with a variable (stored in _config.yml or _data/version.yml for instance).

We can definitely do that for lessons and it shouldn't create too much noise -- one extra PR when lessons sync up with this repo. We can create an action that would submit a pull request to update _includes/lesson_footer.html.

@maxim-belkin
Copy link
Contributor

Using _data/styles_version.yml might be a good idea too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants