Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inconsistency re upgrading to transformer 4.0.0 #124

Merged
merged 6 commits into from
Dec 2, 2020
Merged

fix inconsistency re upgrading to transformer 4.0.0 #124

merged 6 commits into from
Dec 2, 2020

Conversation

MXueguang
Copy link
Member

  1. sentencepiece need to be installed saperately in transformers 4.0.0 for slow Tokenizers e.g. T5Tokenizer.
  2. set use_fast=False for Tokenizers to make sure tokenizers have same behavior as before
  3. change "max_length" padding for T5 to "longest" padding which gives same result with taking 1/3 time.

replicated msmarco-subset
https://colab.research.google.com/drive/1xt0a-EvGO7zprCoBUjtBQFdB4WL9nwuT?usp=sharing

@ronakice
Copy link
Member

ronakice commented Dec 2, 2020

Just a comment, but what happens if we go with fast tokenizers?

@ronakice
Copy link
Member

ronakice commented Dec 2, 2020

Was that the result I was getting?

Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MXueguang
Copy link
Member Author

Was that the result I was getting?

same to the scores in experiments-msmarco-passage-subset.md

@MXueguang
Copy link
Member Author

MXueguang commented Dec 2, 2020

Just a comment, but what happens if we go with fast tokenizers?

MonoBert gives same result as before but monoT5 is not giving same result
so followed https:/huggingface/transformers/releases, to keep the Tokenizer behavior in transformers v3

@ronakice ronakice merged commit 9a1fe70 into castorini:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants