Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change option from model-name-or-path to simpler model, fix flake8 len 120 #40

Merged
merged 2 commits into from
May 29, 2020
Merged

change option from model-name-or-path to simpler model, fix flake8 len 120 #40

merged 2 commits into from
May 29, 2020

Conversation

ronakice
Copy link
Member

No description provided.

@ronakice
Copy link
Member Author

Addresses #39 and change max length to 120 instead as discussed.

rodrigonogueira4
rodrigonogueira4 approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment

@ronakice ronakice merged commit 82dc086 into master May 29, 2020
@ronakice ronakice deleted the model-option-and-flake8-120 branch May 29, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigonogueira4 rodrigonogueira4 rodrigonogueira4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronakice @rodrigonogueira4