Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reflected XSS issue on Filmstrip compare page #1643

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Fix reflected XSS issue on Filmstrip compare page #1643

merged 1 commit into from
Dec 10, 2021

Conversation

tkadlec
Copy link
Contributor

@tkadlec tkadlec commented Dec 10, 2021

Let's apply a little bit of clean-up to the $end parameter on the filmstrip page to avoid XSS issues.

@tkadlec
On the compare page, we were outputting the $end parameter directly w…
24280d5 
…ithout any sanitization which left us vulnerable to a reflective xss attack.

This fixes the issue.
scottjehl
scottjehl approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@scottjehl scottjehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change +1

@scottjehl scottjehl merged commit c1b79fa into master Dec 10, 2021
@scottjehl scottjehl deleted the input-santization branch December 10, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

@scottjehl scottjehl scottjehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkadlec @jefflembeck @scottjehl