Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtest): clean up error on logged out tests #2098

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

jefflembeck
Copy link
Contributor

When too many tests are run by a logged-out user, they should see our current
login and signup links. This also makes it a bit easier to read the code

When too many tests are run by a logged-out user, they should see our current
login and signup links. This also makes it a bit easier to read the code
$msg .= '<li>Access to upcoming betas and new features that will enhance your WebPageTest experience.</li>';
$msg .= '</ul>';
$msg = <<<HTML
<ul class="testerror_loginperks">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so my linter is gonna be mad about this but it'll get fixed next time I touch this

@deathbearbrown
Copy link
Contributor

yess got rid of some of those common.inc references that make my ide sidebar a fancy red line.
Screen Shot 2022-07-06 at 12 17 59 PM

@jefflembeck jefflembeck merged commit 81b42aa into master Jul 6, 2022
@jefflembeck jefflembeck deleted the fix-logged-out-test-error branch July 6, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants