this fixes #2132 for basic auth specifically, but is not yet optimized. This logic could stand to be central and shared #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. This logic could stand to be central and shared
…eir support to experiments. Note: these changes will still not preserve a test['script'] field at all. They simply re-apply customHeaders and auth into the new script we're creating for an experiment. #2132
scottjehl
changed the title
|
Tested and confirmed for auth and custom headers! Will follow up with Issue re cleanup and one small issue surfacing auth info in the compare page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: these changes will still not preserve a test['script'] field at all. They simply re-apply customHeaders and auth into the new script we're creating for an experiment. #2132