Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White links on the homepage #2176

Merged
merged 2 commits into from
Jul 27, 2022
Merged

White links on the homepage #2176

merged 2 commits into from
Jul 27, 2022

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Jul 20, 2022

Fix stuff like:

Screen Shot 2022-07-20 at 7 20 33 PM

Screen Shot 2022-07-20 at 7 20 59 PM

Looks like we have a number of color:#fff and color:inherit overrides, but I didn't touch these.

@tkadlec
Copy link
Contributor

tkadlec commented Jul 21, 2022

Oooo… @stoyan, does this close #1720 ?

@@ -48,7 +48,11 @@ select {
color: #fff;
}

/*
.home a {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will nuke those bottom links in the white boxes
Screen Shot 2022-07-26 at 1 07 17 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! I didn't see these in my local setup.

Do you think these should be the exception (and keep the general "all links are white on the homepage"), since all the rest of the page is dark background? Or I should drop the generic .home a and fix the offending links in the other parts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked around and I couldn't find anything else weird. just those boxes which you can fix by applying a style to the box links

@stoyan
Copy link
Contributor Author

stoyan commented Jul 27, 2022

Oooo… @stoyan, does this close #1720 ?

yup

@stoyan
Copy link
Contributor Author

stoyan commented Jul 27, 2022

White links in the configuration area, sans the notification messages.
Screen Shot 2022-07-27 at 11 05 32 AM
Screen Shot 2022-07-27 at 12 09 01 PM
Screen Shot 2022-07-27 at 12 09 09 PM
Screen Shot 2022-07-27 at 12 09 31 PM

@deathbearbrown deathbearbrown merged commit a132611 into master Jul 27, 2022
@stoyan stoyan deleted the link branch August 29, 2022 16:47
@stoyan
Copy link
Contributor Author

stoyan commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants