Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: set the billing cycle select to annual. Webkit is not our friend #2188

Merged
merged 1 commit into from
Jul 28, 2022
Merged

bugfix: set the billing cycle select to annual. Webkit is not our friend #2188

merged 1 commit into from
Jul 28, 2022

Conversation

deathbearbrown
Copy link
Contributor

To test:
on signup select a MONTHLY plan

use the browser's back button and you should see the billing cycle select set to ANNUAL, not monthly, Monthly was the bug

jefflembeck
jefflembeck approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@jefflembeck jefflembeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to be able to take advantage of this feature, but just making all of them conform is good enough.

@deathbearbrown
Copy link
Contributor Author

I wasn't even getting value shown back... so I have no idea how we'd take advantage of it

@deathbearbrown deathbearbrown merged commit ca647ac into master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefflembeck jefflembeck jefflembeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deathbearbrown @jefflembeck