Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing symbols after application is launched is not allowed #790

Closed
mzilak opened this issue Sep 3, 2020 · 7 comments · Fixed by #844
Closed

Editing symbols after application is launched is not allowed #790

mzilak opened this issue Sep 3, 2020 · 7 comments · Fixed by #844
Assignees
Labels
Milestone

Comments

@mzilak
Copy link

mzilak commented Sep 3, 2020

Editing of symbols on the boards (existing or newly imported) is not allowed after the application is launched. Try to reproduce this in a way that you launch the app (before that the app was not in the recent apps), import some public board and try to edit the title of some symbol. The letters keep coming back. This I noticed only after the editing attempt after launching the app, after that editing works fine.

I tried to record the situation, the video recording is on this link: https://drive.google.com/file/d/1XB-kvPm7TpW7O9IcRYY6kWFDplzG8bEU/view?usp=sharing

@martinbedouret martinbedouret added this to the 1.7.1 milestone Dec 8, 2020
@martinbedouret martinbedouret modified the milestones: 1.7.1, 1.8.0 Dec 23, 2020
@sylvansson
Copy link
Collaborator

@martinbedouret I can look into this if you want.

@martinbedouret
Copy link
Collaborator

@sylvansson Yes! Please go ahead. Take into consideration that this bug is maybe just reproducible in the Android app.

@sylvansson
Copy link
Collaborator

@mzilak I personally cannot reproduce this issue in Android or my browser. Can you still reproduce it on your device? If so, could you tell us which version of the Cboard app you're using?

@mzilak
Copy link
Author

mzilak commented Jan 7, 2021

@sylvansson , yes, I just managed to reproduce it again, Cboard version 1.7.1, device Samsung Galaxy S20.
Maybe if you try to delete the data of the application from the device. I did this, logged in into Cboard, downloaded the public board and tried to edit the symbol. Letters keep coming back like in the upper video.

@sylvansson
Copy link
Collaborator

Thank you! I'll look into it again.

@sylvansson
Copy link
Collaborator

@martinbedouret I was able to reproduce the issue on my smartphone. I'm currently unable to run the project with Cordova to debug though, so this won't be fixed right away.

@martinbedouret
Copy link
Collaborator

no worries @sylvansson , I can take a look.

@martinbedouret martinbedouret linked a pull request Feb 16, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants