Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make current phrase shareable #861

Closed
thoka opened this issue Mar 10, 2021 · 3 comments · Fixed by #880 or #916
Closed

Make current phrase shareable #861

thoka opened this issue Mar 10, 2021 · 3 comments · Fixed by #880 or #916
Assignees
Milestone

Comments

@thoka
Copy link

thoka commented Mar 10, 2021

I would like to be able to share the current phrase, for example to send it via email or copy it into a word processor.

I could imagine multiple ways to support this:

  • copy to clipboard by ctrl+c
  • add a copy to clipboard symbol next to "clear" and "delete"
  • support dragging of the phrase to some other programm
  • add a "share" button to select further options (at best user configurable providers)
@shayc shayc added the feature label Mar 28, 2021
@shayc
Copy link
Collaborator

shayc commented Mar 29, 2021

@thoka great suggestion, how do you imagine the output? Just text or with symbols?
@martinbedouret what do you think? We need to keep the UI simple for the end-user, so "Copy to Clipboard" button will be opt-in from the settings.

@martinbedouret martinbedouret linked a pull request Apr 10, 2021 that will close this issue
@martinbedouret martinbedouret added this to the 1.10.0 milestone Apr 10, 2021
@thoka
Copy link
Author

thoka commented Apr 12, 2021

@thoka great suggestion, how do you imagine the output? Just text or with symbols?

It would be great to be able to have text and text and symbols.
The application could add text with symbols as html and only text as plain text into the clipboard.

@martinbedouret martinbedouret removed this from the 1.10.0 milestone May 2, 2021
@martinbedouret
Copy link
Collaborator

@tomivm assigned.
This was partially implemented on #880 .We have to transform the copy phrase button into a share phrase button. See below:

image

The share phrase button must share the text of the phrase. Also we have to update the text in the settings:

image

@martinbedouret martinbedouret linked a pull request Jun 2, 2021 that will close this issue
@martinbedouret martinbedouret added this to the 1.10.1 milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants