Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sign in with apple #1494

Merged
merged 6 commits into from
Jun 2, 2023

Conversation

tomivm
Copy link
Collaborator

@tomivm tomivm commented May 30, 2023

Feature requested by Apple store
close #1493

RodriSanchez1
RodriSanchez1 previously approved these changes May 30, 2023
@@ -147,6 +168,15 @@ export class WelcomeScreen extends Component {
<FormattedMessage {...messages.facebook} />
</FacebookLoginButton>
)}

{!isAndroid() && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add also !isElectron() until test it!

@RodriSanchez1 RodriSanchez1 dismissed their stale review June 1, 2023 20:42

Changes requested

@tomivm tomivm merged commit 5d01338 into cboard-org:master Jun 2, 2023
@tomivm tomivm deleted the feature/sign-in-with-apple branch June 2, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Apple sign in
2 participants