Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve phrase to be allowed only by logged in users in free countries #1635

Merged
merged 20 commits into from
May 6, 2024

Conversation

maxicapodacqua
Copy link
Contributor

@maxicapodacqua maxicapodacqua commented Dec 12, 2023

Fixes #1627
WIP

Screenshot

image

TODO:

  • Test interaction between PremiumRequiredModal and new modal (will event.stopPropagation break it?)
  • Dev test as a logged-in user
  • Disable feature on logout

@martinbedouret martinbedouret added this to the 1.34.0 milestone Dec 14, 2023
@tomivm
Copy link
Collaborator

tomivm commented Dec 18, 2023

Thanks, @maxicapodacqua great Job getting familiar with the Cboard code.
Excuse me. I pushed some commits to use the same capturer for premium features to also require the user to log in. (this is because right now the only features that gonna require the login of the users in free countries are also premium features. and would be easier than to have 2 different wrappers).
Let me know if you have doubts or comments, please!
Again thank you so much!

@maxicapodacqua maxicapodacqua marked this pull request as ready for review December 18, 2023 19:45
@tomivm tomivm merged commit d24b813 into cboard-org:master May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent enable the 'Improve Phrase' feature when user is not logged
3 participants