Implement online voices from Azure #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvansson
reviewed
Jun 23, 2021
| if (name) { | ||
| voice.name = name; | ||
| } else if (DisplayName) { | ||
| voice.name = `${DisplayName} (${voice.lang}) - ${Gender}`; |
There was a problem hiding this comment.
Should we be using the messages in SpeechProvider.messages.js here?
| if (name) { | ||
| voice.name = name; | ||
| } else if (DisplayName) { | ||
| voice.name = `${DisplayName} (${voice.lang}) - ${Gender}`; |
There was a problem hiding this comment.
Very minor detail but there are two spaces before the opening parenthesis instead of one.
| @@ -77,7 +81,11 @@ const Speech = ({ | |||
| secondary={getVoiceLabel(voice)} | |||
| /> | |||
| </ListItem> | |||
| <ListItem divider aria-label={intl.formatMessage(messages.pitch)}> | |||
| <ListItem | |||
| disabled={voice.voiceSource === 'cloud' ? true : false} | |||
There was a problem hiding this comment.
Maybe we could add a boolean property like isCloud to voice objects so that we can just do disabled={voice.isCloud}.
tomivm
reviewed
Jun 30, 2021
tomivm
reviewed
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.