Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normal modem to all pockets #1923

Draft
wants to merge 1 commit into
base: mc-1.20.x
Choose a base branch
from

Conversation

Wojbie
Copy link
Contributor

@Wojbie Wojbie commented Aug 1, 2024

Allow me to preface that this is a draft because this is most likely not a proper way to implement this. This is just created as showcase/experimentation space to allow interested parties to see how this would feel.

image

What this is:

This basic bodge permanently attaches basic modem to top slot of all pockets. For base mod it means that one can attach second basic modem to double amount of channels they can open, ender modem to allow better range/interdimensionality or a speaker to add sound while still having basic functionality of basic modem installed. With other peripheral mods it means one can use peripherals from those mods on pocket without loosing network access. This does keep pockets as one swappable peripheral, it just add a unswapable internal top modem that increased functionality of pockets.

This is example of Suggestion A from #1406 in same vein that #1689 is a example of Suggestion B.

Despite fact that this is not proper way to do it it seems to be working correctly from tests i have preformed.
image
image

As a side note that highly amuses me:
Turns out colony4cc have been doing something similiar for last 4 years so this is not exactly unexplored solution.

Additionally i would like to thank SquidDev in #1916 for pointing out to me this is possible to bodge in this simple way. 😄

EDIT: And if any of you wanna to test how this PR works you can use jar from this PR checks to try it out. https:/cc-tweaked/CC-Tweaked/actions/runs/10193099406/artifacts/1763405706

@uecasm
Copy link

uecasm commented Aug 3, 2024

Hi, author of colony4cc here. My evil hack doesn't add a modem to all pocket computers; it applies only when a specific "composite" peripheral is attached. Basically I made a specific upgrade that's intended to behave identically to a modem plus my regular peripheral, which it does by attaching the modem to the back as normal and my peripheral to the bottom. (There's another evil hack to prevent the modem from hijacking the pocket computer's light.)

As such, it's sort of like Suggestion A or C in #1406. I'd definitely prefer a less-hacky solution for this sort of use case. 😀


One caveat with the implementation in this particular PR is that it's only a standard modem, not an ender modem; whereas I wanted to allow both options. You could perhaps base that on the computer type? Though the ender modem is more expensive than an advanced computer.

@Wojbie
Copy link
Contributor Author

Wojbie commented Aug 17, 2024

One caveat with the implementation in this particular PR is that it's only a standard modem, not an ender modem; whereas I wanted to allow both options.

That is explicit choice on my part as i just wanted to add most basic standard wireless networking option as baseline so anything else is a upgrade choice by user. If this idea somehow gets actually implemented i feel it would make most sense to keep it this way. As whole point was just to add basic networking capability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants