Skip to content

Commit

Permalink
Apply @W0ni suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
commial authored Apr 4, 2024
1 parent 113ed96 commit 4c2a4f3
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions doc/jitter/jitter.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@
"source": [
"For now, our emulator is an empty box. It has:\n",
"\n",
"* registers, reachable from the `.cpu` attribute. There are initiallized to 0\n",
"* a virtual memory, reachable from the `.vm` attribute. It starts empty"
"* registers, reachable from the `.cpu` attribute. These are initiallized to 0.\n",
"* a virtual memory, reachable from the `.vm` attribute. It starts empty."
]
},
{
Expand Down Expand Up @@ -400,7 +400,8 @@
"jitter.run(0x1000)\n",
"\n",
"# The execution ends with an error, which is expected.\n",
"# Indeed, we RET on 0x1337beef, which is not mapped in memory, hence the \"WARNING: address 0x1337BEEF is not mapped in virtual memory\""
"# Indeed, we RET on 0x1337beef, which is not mapped in memory,\n",
"# hence the \"WARNING: address 0x1337BEEF is not mapped in virtual memory\""
]
},
{
Expand Down Expand Up @@ -434,10 +435,10 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"If a breakpoint callback return `True`, the emulation continue.\n",
"If a breakpoint callback returns `True`, the emulation continues.\n",
"Otherwise, the emulation will stop and the value returned by the `jitter.continue_run()` call is the callback return value.\n",
"\n",
"Note: if one need to add more argument to the callback, there are many Pythonic way to do it.\n",
"Note: if one need to add more arguments to the callback, there are many Pythonic way to do it.\n",
"For instance, one can use `lambda` to capture an argument or object instance (ie. `jitter.add_breakpoint(address, obj.callback)` with a `def callback(self, jitter)` inside the `obj` definition).\n",
"\n",
"The breakpoint mechanism is used to implement several features. For instance:\n",
Expand Down

0 comments on commit 4c2a4f3

Please sign in to comment.