Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: add a notebook on emulation API #1480

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

commial
Copy link
Contributor

@commial commial commented Apr 3, 2024

No description provided.

Copy link
Contributor

@W0ni W0ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @commial,

I added some comments ;)

doc/jitter/jitter.ipynb Outdated Show resolved Hide resolved
doc/jitter/jitter.ipynb Outdated Show resolved Hide resolved
doc/jitter/jitter.ipynb Outdated Show resolved Hide resolved
doc/jitter/jitter.ipynb Outdated Show resolved Hide resolved
"cell_type": "markdown",
"metadata": {},
"source": [
"#### Exercice 1 - Spoiler\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to "hide" the spoil behind the spoiler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, no.
Some hacks exists, such as using white-colored text, but regarding what the spoilers contain, IMHO it is safe to keep them that way

doc/jitter/jitter.ipynb Outdated Show resolved Hide resolved
@commial
Copy link
Contributor Author

commial commented Apr 4, 2024

Thanks for your suggestions @W0ni !

@W0ni
Copy link
Contributor

W0ni commented Apr 4, 2024

Hi @commial ,

Thanks again for your PR, these notebooks are very useful for beginners. I proposed a fix for another typo which was in my suggestions.

@serpilliere serpilliere merged commit 0fffa14 into cea-sec:master Apr 5, 2024
3 checks passed
@serpilliere
Copy link
Contributor

Thank you @commial for the PR!
And thank you @W0ni for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants