Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state fraud proofs (celestia): verification logic #55

Open
liamsi opened this issue Mar 20, 2021 · 2 comments
Open

state fraud proofs (celestia): verification logic #55

liamsi opened this issue Mar 20, 2021 · 2 comments
Labels
needs:adr item is a substantial change that require an ADR before progress can be made

Comments

@liamsi
Copy link
Member

liamsi commented Mar 20, 2021

Verifying a fraud proof requires knowledge of the state logic. We need to investigate which parts will have to live:

  1. in the abci app itself
  2. in the Cosmos-SDK
  3. lazyledger-core

Lazyledger-core most likely should provide a simple library (reactor?) to gossip fraud proofs. Maybe the evidence pool can be re-used for that. This should be as light-weight as possible, as we would want light-clients to also participate in the gossiping.
Fraud proofs will be gossiped by Celestia-nodes: https:/celestiaorg/celestia-node
Additionally, celestia-core needs to collect the intermediate state in Block.Data (celestiaorg/celestia-core#84).

The Cosmos-SDK probably needs modifications to produce these intermediate state roots (celestiaorg/cosmos-sdk#8 and celestiaorg/cosmos-sdk#9).

Fraud proofs generation and verification could happen in a separate module/in the lazyledger-app itself.

The overall design should be part of rollkit/rollkit#23 too. ADRs that link to each other in the particular repositories will inform this design document.

Ideally, the design should be independent of which tree is actually used (iavl/smt/other) (ref: celestiaorg/cosmos-sdk#8)

@Wondertan
Copy link
Member

@liamsi, looks like the description needs to be updated according to the latest plans

@liamsi
Copy link
Member Author

liamsi commented Aug 17, 2021

Thanks for the nudge. Updated the gossiping part.

@liamsi liamsi changed the title fraud proofs: verification logic state fraud proofs (celestia): verification logic Dec 5, 2021
@evan-forbes evan-forbes added investigation item tracks efforts related to an investigation. does not always require a PR to close. and removed T:investigate labels May 13, 2024
@evan-forbes evan-forbes added needs:adr item is a substantial change that require an ADR before progress can be made and removed investigation item tracks efforts related to an investigation. does not always require a PR to close. labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:adr item is a substantial change that require an ADR before progress can be made
Projects
None yet
Development

No branches or pull requests

3 participants