Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to tm v0.34.23 #906

Merged
merged 73 commits into from
Dec 13, 2022
Merged

chore: update to tm v0.34.23 #906

merged 73 commits into from
Dec 13, 2022

Conversation

cmwaters
Copy link
Contributor

@cmwaters cmwaters commented Dec 12, 2022

Closes: #870

Original ref: tendermint/tendermint@v0.34.20...v0.34.23

(63 commits 531 files changed) - Seems like the first 8 commits were never ported to celestia

M. J. Fromberger and others added 30 commits July 12, 2022 10:28
A manual cherry-pick of 9e64c95.

The way this was originally structured, we reacquired the lock after issuing
the initial ABCI CheckTx call, only to immediately release it. Restructure the
code so that this redundant acquire is no longer necessary.
A manual backport of #8984.

This case is symmetric to what we did for CheckTx calls, where we release the
mempool mutex to ensure callbacks can fire during call setup.  We also need
this behaviour for application flush, for the same reason: The caller holds the
lock by contract from the Mempool interface.
Bumps [google.golang.org/grpc](https:/grpc/grpc-go) from 1.47.0 to 1.48.0.
- [Release notes](https:/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.47.0...v1.48.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sam Kleinman <[email protected]>
…port #9000) (#9004)

This is a manual cherry-pick of commit b94470a.

In the original implementation transactions evicted for priority were also
removed from the cache. In addition, remove expired transactions from the
cache.

Related:

- Add Has method to cache implementations.
- Update tests to exercise this condition.
In the v0.34 line, the socket and gRPC clients require explicit flushes to
ensure that the client and server have received an async request.  Add these
calls explicitly where required in the backport of the priority mempool.

In addition, the gRPC client's flush plumbing was not fully hooked up in the
v0.34 line, so this change includes that update as well.
Bumps [github.com/golangci/golangci-lint](https:/golangci/golangci-lint) from 1.46.2 to 1.47.0.
- [Release notes](https:/golangci/golangci-lint/releases)
- [Changelog](https:/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.46.2...v1.47.0)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ort #9030) (#9033)

(manual cherry-pick of commit 22ed610)
Bumps [github.com/BurntSushi/toml](https:/BurntSushi/toml) from 1.1.0 to 1.2.0.
- [Release notes](https:/BurntSushi/toml/releases)
- [Commits](BurntSushi/toml@v1.1.0...v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/BurntSushi/toml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/golangci/golangci-lint](https:/golangci/golangci-lint) from 1.47.1 to 1.47.2.
- [Release notes](https:/golangci/golangci-lint/releases)
- [Changelog](https:/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.47.1...v1.47.2)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/golangci/golangci-lint](https:/golangci/golangci-lint) from 1.47.2 to 1.48.0.
- [Release notes](https:/golangci/golangci-lint/releases)
- [Changelog](https:/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.47.2...v1.48.0)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
*backport of sam/abci-responses

Co-authored-by: William Banfield <[email protected]>
*bump linter to 1.47

Co-authored-by: William Banfield <[email protected]>
* update to 1.18

Co-authored-by: William Banfield <[email protected]>
* update last responses key
I noticed today that this wasn't enabled.

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
* Initial commit

* Add three timeouts and align pseudocode better with existing algorithm

* Align protocol with Tendermint code and add find valid value mechanism

* Prepare to Nuke Develop (#47)

* state -> step

* vote -> v

* New version of the algorithm and the proof

* New version of the algorithm and the proofs

* Added algorithm description

* Add algorithm description

* Add introduction

* Add conclusion

* Add conclusion file

* fix warnings (caption was defined twice)

- only the latter is used anyways (centers captions)
- this makes it possible to autom. building the paper

* Update grammar

* s/state_p/step_p

* Address Ismail's comments

* intro: language fixes

* definitions: language fixes

* consensus: various fixes

* proof: some fixes

* try to improve reviewability

* \eq -> =

* textwrap to 79

* various minor fixes

* proof: fix itemization

* proof: more minor fixes

* proof: timeouts are functions

* proof: fixes to lemma6

* Intro changes and improve title page

* Add Marko and Ming to acks

* add readme

* Format algorithm correctly

Clarify condition semantic and timeouts

Improve descriptions

* patform -> platform

* Ensure that rules are mutually exclusive

- various clarifications and small improvements

* Release v0.6

* small nits for smoother readability

* This PR is to create signed commits to be able to merge (#50)

Signed-off-by: Marko Baricevic <[email protected]>

* Add consesnus and blockchain specs, (#52)

- Open questions
	- Do  we want to split lite client work from consesnsus
	- From the blockchain spec, is encoding nessecary in the spec

Signed-off-by: Marko Baricevic <[email protected]>

* Add ABCI SPEC (#51)

- move the abci spec from tendermint to spec repo

Signed-off-by: Marko Baricevic <[email protected]>

* spec/consensus/signing: add more details about nil and amnesia (#54)

- Add more details about nil votes and about amnesia attacks

Signed-off-by: Marko Baricevic <[email protected]>

* Add Section for P2P (#53)

* Add Section for P2P

- moved over the section on p2p

Signed-off-by: Marko Baricevic <[email protected]>

* add some more files

Signed-off-by: Marko Baricevic <[email protected]>

* Fix model section

* Add non-recursive specification of Bisection algorithm

- Fix timing issues by introducing Delta parameter

* spec: update spec with tendermint updates (#62)

* spec: update spec with tendermint updates

- this in preperation of deleting the spec folder in docs in tendermint/tendermint

Signed-off-by: Marko Baricevic <[email protected]>

* spec: added in reactors & p2p

Signed-off-by: Marko Baricevic <[email protected]>

* spec: update readme in spec to comply with docs site

Signed-off-by: Marko Baricevic <[email protected]>

* docs: addded more changes from tednermint/tendermint

Signed-off-by: Marko Baricevic <[email protected]>

* reflect breaking changes made to Commit (#63)

* reflect breaking changes made to Commit

PR: tendermint/tendermint#4146
Issue: tendermint/tendermint#1648

* types: rename Commit#Precommits to Signatures

* update BlockIDFlagAbsent comment

* remove iota

* Clean up error conditions and simplify pseudocode

* Apply suggestions from code review

Co-Authored-By: Anca Zamfir <[email protected]>

* Add spec doc about unconditional_peer, persistent_peers_max_dial of ADR-050 (#68)

* Add spec doc about unconditional_peer_ids, persistent_peers_max_dial_period of ADR-050

* Add indefinitely dialing condition

* Add sr25519 amino documentation (#67)

* sr25519 amino

* Update spec/blockchain/encoding.md

Co-Authored-By: Marko <[email protected]>

* some suggestions for pseuodocode changes

* Improved error handling

* Add explanation on difference between trusted models

* Address reviewer's comments

* Addressing reviewer's comments

* Separating algorithm from proofs

* Intermediate commit (aligning spec with the code)

* Removing Store from API and providing end-to-end timing guarantees

* Address reviewer comment's. Intermediate commit

* light client dir and readmes

* titles

* add redirects

* add diagram

* detection TODO

* fix image

* update readme

* Aligh the correctness arguments with the pseudocode changes

* lite->light

* Fix link in readme

./light -> ./light-client

* p2p: Merlin based malleability fixes (#72)

* Update the secret connection spec with the use of merlin to eliminte handshake malleability

* Update spec/p2p/peer.md

Co-Authored-By: Anton Kaliaev <[email protected]>

* Update spec/p2p/peer.md

Co-Authored-By: Anton Kaliaev <[email protected]>

* Update spec/p2p/peer.md

Co-Authored-By: Anton Kaliaev <[email protected]>

Co-authored-by: Anton Kaliaev <[email protected]>

* docs: update specs to remove cmn (#77)

- cmn was remvoed in favor of sub pkgs. cmn.kvpair is now kv.pair

Signed-off-by: Marko Baricevic <[email protected]>

* evidence: Add time to evidence params (#69)

* evidence: Add time to evidence params

- this pr is grouped together with tendermint/tendermint#4254, once that PR is merged then this one can be as well.

Signed-off-by: Marko Baricevic <[email protected]>

* remove note

Signed-off-by: Marko Baricevic <[email protected]>

* Apply suggestions from code review

Co-Authored-By: Anton Kaliaev <[email protected]>

Co-authored-by: Anton Kaliaev <[email protected]>

* update link to the pex reactor

* add markdown link checker

* changed tab spacing

* removed folder-path flag

* first attempt at fixing all links

* second attempt at fixing all links

* codeowners: add code owners (#82)

* codeowners: add code owners

- added some codeowners
please comment if youd like to be added as well.

Signed-off-by: Marko Baricevic <[email protected]>

* remove comment of repo maintainers

* remove .idea dir (#83)

Signed-off-by: Marko Baricevic <[email protected]>

* RFC-001: configurable block retention (#84)

* Added RFC for truncated block history coordination

* Clarified minimum block retention

* Added hard checks on block retention and snapshot interval, and made some minor tweaks

* Genesis parameters are immutable

* Use local config for snapshot interval

* Reordered parameter descriptions

* Clarified local config option for snapshot-interval

* rewrite for ABCI commit response

* Renamed RFC

* add block retention diagram

* Removed retain_blocks table

* fix image numbers

* resolved open questions

* image quality

* accept RFC-001 (#86)

* abci: add basic description of ABCI Commit.ResponseHeight (#85)

Documentation for block pruning, once it's merged: tendermint/tendermint#4588.

Minimum documentation, for now - we probably shouldn't encourage using this feature too much until we release state sync.

* abci: add MaxAgeNumBlocks/MaxAgeDuration to EvidenceParams (#87)

* abci: update MaxAgeNumBlocks & MaxAgeDuration docs (#88)

* document state sync ABCI interface and P2P protocol (#90)

The corresponding Tendermint PRs are tendermint/tendermint#4704 and tendermint/tendermint#4705.

* Revert "document state sync ABCI interface and P2P protocol (#90)" (#92)

This reverts commit 9842b4b.

* blockchain: change validator set sorting method (#91)

* abci: specify sorting of RequestInitChain.Validators

* blockchain: change validator sorting method

Refs tendermint/tendermint#2478

* reactors/pex: specify hash function (#94)

https:/tendermint/tendermint/pull/4810/files

* document state sync ABCI interface and P2P protocol (#93)

* Revert "Revert "document state sync ABCI interface and P2P protocol (#90)" (#92)"

This reverts commit 90797ce.

* update with new enum case

* fix links

Co-authored-by: Erik Grinaker <[email protected]>

* Update evidence params with MaxNum (#95)

evidence params now includes maxNum which is the maximum number of evidence that can be committed on a single block

* reactors/pex: masked IP is used as group key (#96)

* spec: add ProofTrialPeriod to EvidenceParam (#99)

* spec: modify Header.LastResultsHash (#97)

Refs: tendermint/tendermint#1007
PR: tendermint/tendermint#4845

* spec: link to abci server implementations (#100)

* spec: update evidence in blockchain.md (#108)

now evidence reflects the actual evidence present in the tendermint repo

* abci: add AppVersion to ConsensusParams (#106)

* abci: tweak node sync estimate (#115)

* spec/abci: expand on Validator#Address (#118)

Refs tendermint/tendermint#3732

* blockchain: rename to core (#123)

* blockchain: remove duplicate evidence sections (#124)

* spec/consensus: canonical vs subjective commit

Refs tendermint/tendermint#2769

* Apply suggestions from code review

Co-authored-by: Igor Konnov <[email protected]>

* update spec with the removal of phantom validator evidence (#126)

* bring blockchain back

* add correct links

* spec: revert event hashing (#132)

* Evidence time is sourced from block time (#138)

* RFC-002: non-zero genesis (#119)

* abci: add ResponseInitChain.app_hash (#140)

* update hashing of empty inputs, and initial block LastResultsHash (#141)

* update evidence verification (#139)

* accept RFC-002 (#142)

* add description of arbitrary initial height (#135)

* update ResponseInitChain.app_hash description (#143)

* remove unused directories and update README (#145)

This change removes unused directories (`papers` and `research`) 
and updates the README to reflect our strategy for merging the 
informalsystems/tendermint-rs specs into this repository.

Partially addresses #121.

* ci: add markdown linter (#146)

* ci: add dependabot config (#148)

* build(deps): bump gaurav-nelson/github-action-markdown-link-check from 0.6.0 to 1.0.7 (#149)

Bumps [gaurav-nelson/github-action-markdown-link-check](https:/gaurav-nelson/github-action-markdown-link-check) from 0.6.0 to 1.0.7.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: add sections to abci (#150)

* spec: update abci events (#151)

* spec: extract light-client to its own directory (#152)

Co-authored-by: Callum Waters <[email protected]>

* spec: remove evidences (#153)

* add a stale bot (#134)

* Current versions of light client specs from tendermint-rs (#158)

* current versions of light client specs from tendermint-rs

* markdown lint

* linting

* links

* links

* links

Co-authored-by: Marko Baricevic <[email protected]>

* Fastsync spec from tendermint-rs (#157)

* fastsync spec from tendermint-rs

* fixed broken link

* fixed linting

* more fixes

* markdown lint

* move fast_sync to rust-spec

Co-authored-by: Marko Baricevic <[email protected]>

* Update README.md (#160)

* spec/reactors/mempool: batch txs per peer (#155)

* spec/reactors/mempool: batch txs per peer

Refs tendermint/tendermint#625

* update

* spec: Light client attack detector (#164)

* start with new detection and evidence spec

* more definitions at top

* sketch of functions

* pre post draft

* evidence proof

* typo

* evidence theory polished

* some TODOs resolved

* more TODOs

* links

* second to last revision before PR

* links

* I will read once more and then make a PR

* removed peer handling definitions

* secondary

* ready to review

* detector ready for review

* Update rust-spec/lightclient/detection/detection.md

Co-authored-by: Zarko Milosevic <[email protected]>

* Update rust-spec/lightclient/detection/detection.md

Co-authored-by: Zarko Milosevic <[email protected]>

* Update rust-spec/lightclient/detection/detection.md

Co-authored-by: Zarko Milosevic <[email protected]>

* Update rust-spec/lightclient/detection/detection.md

Co-authored-by: Zarko Milosevic <[email protected]>

* Update rust-spec/lightclient/detection/detection.md

Co-authored-by: Zarko Milosevic <[email protected]>

* Update rust-spec/lightclient/detection/detection.md

Co-authored-by: Zarko Milosevic <[email protected]>

* Update rust-spec/lightclient/detection/detection.md

* skip-trace

* PossibleCommit explained

* Update rust-spec/lightclient/detection/detection.md

Co-authored-by: Zarko Milosevic <[email protected]>

* comments by Zarko

* renamed and changed link in README

Co-authored-by: Zarko Milosevic <[email protected]>

* fixed an overlooked conflict (#167)

* describe valset sorting according to v0.34 requirements (#169)

* evidence: update data structures (#165)

* fix markdown linter (#172)

* TLA+ specs from MBT revision (#173)

* remove setOption (#181)

* spec: protobuf changes (#156)

Co-authored-by: Anton Kaliaev <[email protected]>

* first check latest with secondary (#184)

* Extending the blockchain specification (in the light client) to produce different ratios of faults (#183)

* cleaning unused definitions

* introduced the ratio of faulty processes

* Update README.md (#185)

* build(deps): bump gaurav-nelson/github-action-markdown-link-check from 1.0.7 to 1.0.8 (#188)

Bumps [gaurav-nelson/github-action-markdown-link-check](https:/gaurav-nelson/github-action-markdown-link-check) from 1.0.7 to 1.0.8.
- [Release notes](https:/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.7...e3c371c)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* spec: update light client verification to match supervisor (#171)

* VDD renaming of verification spec + links fixed

* latest()

* backwards

* added TODOs

* link in old file to new name

* better text

* revision done. needs one more round of reading

* renamed constants in 001 according to TLA+ and impl

* ready for PR

* forgot linting

* Update rust-spec/lightclient/verification/verification_002_draft.md

* Update rust-spec/lightclient/verification/verification_002_draft.md

* added lightstore function needed for supervisor

* added lightstore functions for supervisor

* ident

* Update rust-spec/lightclient/verification/verification_002_draft.md

* github: issue template for proposals (#190)

* Sequential Supervisor (#186)

* move from tendermint-rs but needs discussion

* markdown lint

* TODO links replaced

* links

* links

* links lint

* Update rust-spec/lightclient/supervisor/supervisor.md

* Update rust-spec/lightclient/supervisor/supervisor.md

* Update rust-spec/lightclient/supervisor/supervisor.md

* Update rust-spec/lightclient/supervisor/supervisor.md

* moved peer handling definitions to supervisor

* polishing

* rename

* Update rust-spec/lightclient/supervisor/supervisor_001_draft.md

* Update rust-spec/lightclient/supervisor/supervisor_001_draft.md

* changes to maintain StateVerified again

* ready for changes in verification

* start of supervisor

* module name

* fixed

* more details

* supevisor completed. Now I have to add function to verification

* ready for review

* tla comment

* removed issues

* Update rust-spec/lightclient/supervisor/supervisor_001_draft.md

* intro text fixed

* indentation

* Update rust-spec/lightclient/supervisor/supervisor_001_draft.md

* comment to entry points

Co-authored-by: Marko Baricevic <[email protected]>

* RFC: adopt zip 215 (#144)

Co-authored-by: Robert Zaremba <[email protected]>

* Core: move validation & data structures together (#176)

Co-authored-by: Callum Waters <[email protected]>

* docs: make blockchain not viewable (#211)

* evidence: update data structures to reflect added support of abci evidence (#213)

* encoding: add secp, ref zip215, tables (#212)

* Detector English Spec ready (#215)

Add detector English spec

* add Ivy proofs (#210)

* add Ivy proofs

* fix docker-compose command

* Light client detector spec in TLA+ and refactoring of light client verification TLA+ spec (#216)

Add light client detector spec in TLA+

* abci: lastcommitinfo.round extra sentence (#221)

* abci: add abci_version to requestInfo (#223)

* BFT requires _less than_ 1/3 faulty validators (#228)

Thanks fo spotting the imprecision in the text, @shahankhatch !

* Draft of evidence handling for discussion (#225)

* start with accountability deliverable

* problem statement

* draft function

* quite complete draft. ready to discuss with Igor

* Update isolate-attackers_001_draft.md

* Update isolate-attackers_001_draft.md

* Update isolate-attackers_001_draft.md

* Update isolate-attackers_001_draft.md

* Update isolate-attackers_001_draft.md

* ready for TLA+ to take over

* isolate

* isolateamnesiatodos

* Update isolate-attackers_001_draft.md

* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md

Co-authored-by: Igor Konnov <[email protected]>

* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md

Co-authored-by: Igor Konnov <[email protected]>

* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md

Co-authored-by: Igor Konnov <[email protected]>

* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md

Co-authored-by: Igor Konnov <[email protected]>

* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md

Co-authored-by: Igor Konnov <[email protected]>

* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md

Co-authored-by: Igor Konnov <[email protected]>

* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md

Co-authored-by: Igor Konnov <[email protected]>

* Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md

Co-authored-by: Igor Konnov <[email protected]>

* The TLA+ specification of the attackers detection (#231)

* the working attackers isolation spec, needs more comments

* the TLA+ spec of the attackers isolation

* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#233)

Bumps [gaurav-nelson/github-action-markdown-link-check](https:/gaurav-nelson/github-action-markdown-link-check) from 1.0.8 to 1.0.11.
- [Release notes](https:/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.8...2a60e0f)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Computing attack types (#232)

Add light attack evidence handling

* Update README.md (#234)

* p2p: update frame size (#235)

Reflect the change made in tendermint/tendermint#5805

The MTU (Maximum Transmission Unit) for Ethernet is 1500 bytes.
The IP header and the TCP header take up 20 bytes each at least (unless
optional header fields are used) and thus the max for (non-Jumbo frame)
Ethernet is 1500 - 20 -20 = 1460
Source: https://stackoverflow.com/a/3074427/820520

* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#239)

Bumps [gaurav-nelson/github-action-markdown-link-check](https:/gaurav-nelson/github-action-markdown-link-check) from 1.0.11 to 1.0.12.
- [Release notes](https:/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.11...0fe4911)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* layout: add section titles (#240)

* reactors: remove bcv1 (#241)

* abci: rewrite to proto interface (#237)

* Update supervisor_001_draft.md (#243)

* spec: remove reactor section (#242)

Co-authored-by: Tess Rinearson <[email protected]>

* non-critical bugfix in the TLA+ spec (found by new version of apalache) (#244)

* params: remove block timeiota (#248)

* proto: add files (#246)

Co-authored-by: Erik Grinaker <[email protected]>

* proto: modify height int64 to uint64 (#253)

* abci: note on concurrency (#258)

Co-authored-by: Marko <[email protected]>

* spec: merge rust-spec (#252)

* Fix list of RFCs (#266)

* readme: cleanup (#262)

* modify readme

* add rfc and proto

* add rust=spec back to avoid breakage

* lint readme

* genesis: Explain fields in genesis file (#270)

* describe the genesis

* Update spec/core/genesis.md

Co-authored-by: Dev Ojha <[email protected]>

* Apply suggestions from code review

Co-authored-by: Callum Waters <[email protected]>

* add wording on app_state

* Update spec/core/genesis.md

Co-authored-by: Callum Waters <[email protected]>

Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: Callum Waters <[email protected]>

* p2p: links (#268)

* fix links

* fix more links

* Proposer-based timestamp specification (#261)

* added proposer-based timestamp spec

* Update spec/consensus/proposer-based-timestamp/pbts_001_draft.md

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update spec/consensus/proposer-based-timestamp/pbts_001_draft.md

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update spec/consensus/proposer-based-timestamp/pbts-algorithm_001_draft.md

Co-authored-by: Marko <[email protected]>

* Update spec/consensus/proposer-based-timestamp/pbts-algorithm_001_draft.md

* Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_001_draft.md

Co-authored-by: Callum Waters <[email protected]>

* fixes from PR

Co-authored-by: Josef Widder <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: Callum Waters <[email protected]>

* abci: reorder sidebar (#282)

* ABCI++ RFC (#254)

* ABCI++ RFC

This commit adds an RFC for ABCI++, which is a collection of three new phases of communication between the consensus engine and the application.

Co-authored-by: Sunny Aggarwal <[email protected]>

* Fix bugs pointed out by @liamsi

* Update rfc/004-abci++.md

Co-authored-by: Federico Kunze <[email protected]>

* Fix markdown lints

* Update rfc/004-abci++.md

Co-authored-by: Ismail Khoffi <[email protected]>

* Update rfc/004-abci++.md

Co-authored-by: Tess Rinearson <[email protected]>

* Update rfc/004-abci++.md

Co-authored-by: Tess Rinearson <[email protected]>

* Add information about the rename in the context section

* Bold RFC

* Add example for self-authenticating vote data

* More exposition of the term IPC

* Update pros / negatives

* Fix sentence fragment

* Add desc for no-ops

Co-authored-by: Sunny Aggarwal <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Tess Rinearson <[email protected]>

* RFC: ReverseSync - fetching historical data (#224)

* core: update a few sections  (#284)

* p2p: update state sync messages for reverse sync (#285)

* Update README.md (#286)

* rpc: define spec for RPC (#276)

* add rpc spec and support outline

* add json

* add more routes remove unneeded ones

* add rest of rpc endpoints

* add jsonrpc calls

* add more jsonrpc calls

* fix blockchain

* cleanup unused links and add links to repos

* Update spec/rpc/README.md

Co-authored-by: Callum Waters <[email protected]>

* add missing param from consensus param

* Update spec/rpc/README.md

Co-authored-by: Callum Waters <[email protected]>

* Update spec/rpc/README.md

Co-authored-by: Callum Waters <[email protected]>

* fix cast and add doc to readme

Co-authored-by: Callum Waters <[email protected]>
Co-authored-by: Marko Baricevic <[email protected]>

* A few improvements to the Ivy proof (#288)

* Avoid quantifier alternation cycle

The problematic quantifier alternation cycle arose because the
definition of accountability_violation was unfolded.

This commit also restructures the induction proof for clarity.

* add count_lines.sh

* fix typo and add forgotten complete=fo in comment

Co-authored-by: Giuliano <[email protected]>

* Fixed a broken link (#291)

* fix message type for block-sync (#298)

* lint: fix lint errors (#301)

* build(deps): bump actions/stale from 3 to 3.0.18 (#300)

Bumps [actions/stale](https:/actions/stale) from 3 to 3.0.18.
- [Release notes](https:/actions/stale/releases)
- [Commits](actions/stale@v3...v3.0.18)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump actions/stale from 3.0.18 to 3.0.19 (#302)

Bumps [actions/stale](https:/actions/stale) from 3.0.18 to 3.0.19.
- [Release notes](https:/actions/stale/releases)
- [Commits](actions/stale@v3.0.18...v3.0.19)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* rename HasVote to ReceivedVote (#289)

* add a changelog to track changes (#303)

* add a changelog to track changes

* Update CHANGELOG.md

Co-authored-by: Callum Waters <[email protected]>

Co-authored-by: Callum Waters <[email protected]>

* rpc: clarify timestamps (#304)

* clarify timestamps

* changelog entry

* Update spec/rpc/README.md

Co-authored-by: Callum Waters <[email protected]>

Co-authored-by: Callum Waters <[email protected]>

* rpc: add chunked genesis endpoint (#299)

* rpc: add chunked genesis endpoint

* fix lint

* feedback

* add info about error

* fix lint

Co-authored-by: marbar3778 <[email protected]>

* update ResponseCheckTx (#306)

* rpc: Add totalGasUSed to block_results response (#308)

* Add C++ code generation and test scenario (#310)

* add parameters to byzantine send action

* make net not trusted

it's not necessary since for proofs Ivy will assume that the environment
does not break action preconditions

* use require instead of assume

it seems that assume is not checked when other isolates call!

* add comment

* add comment

* run with random seed

* make domain model extractable to C++

* substitute require for assume

assumes in an action are not checked when the action is called! I.e.
they place no requirement on the caller; we're just assuming that the
caller is going to do the right thing. This wasn't very important here
but it leade to a minor inconsistency slipping through.

* make the net isolate not trusted

there was no need for it

* add tendermint_test.ivy

contains a simple test scenario that show that the specification is no
vacuuous

* update comment

* add comments

* throw if trying to parse nset value in the repl

* add comment

* minor refactoring

* add new pex messages (#312)

* build(deps): bump gaurav-nelson/github-action-markdown-link-check (#313)

Bumps [gaurav-nelson/github-action-markdown-link-check](https:/gaurav-nelson/github-action-markdown-link-check) from 1.0.12 to 1.0.13.
- [Release notes](https:/gaurav-nelson/github-action-markdown-link-check/releases)
- [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.12...1.0.13)

---
updated-dependencies:
- dependency-name: gaurav-nelson/github-action-markdown-link-check
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update spec to reference currently used timestamp type (#317)

* build(deps): bump actions/stale from 3.0.19 to 4 (#319)

Bumps [actions/stale](https:/actions/stale) from 3.0.19 to 4.
- [Release notes](https:/actions/stale/releases)
- [Changelog](https:/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v3.0.19...v4)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* address discrepancies between spec and implementation (#322)

* update proto files for release (#318)

* stale bot: ignore issues (#325)

* evidence: add section explaining evidence (#324)

* statesync: new messages for gossiping consensus params (#328)

* rpc: update peer format in specification in NetInfo operation (#331)

* Update supervisor_001_draft.md (#334)

* core: text cleanup (#332)

* abci: clarify what abci stands for (#336)

* abci: clarify what abci stands for

* link to abci type protos.

* abci: clarify connection use in-process (#337)

* abci: clarify connection use in-process

* Update abci.md

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* invert abci explanations

* lint++

* lint++

* lint++

* lint++

Co-authored-by: M. J. Fromberger <[email protected]>

* proto: move proto files under the correct directory related to their package name (#344)

* abci.md fixup (#339)

* abci: points of clarification ahead of v0.1.0

* lint++

* typo

* lint++

* double word score

* grammar

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* Update spec/abci/abci.md

Co-authored-by: M. J. Fromberger <[email protected]>

* pr feedback

* wip

* update non-zero status code docs

* fix event description

* update CheckTx description

Co-authored-by: M. J. Fromberger <[email protected]>

* Update supervisor_001_draft.md (#333)

* Update supervisor_001_draft.md

If the only node in the *FullNodes* set is the primary, that was just deemed faulty, we can't find honest primary.

* Update supervisor_001_draft.md

* light: update initialization description (#320)

* apps.md fixups (#341)

* wip

* wip

* wip

* remove comments in favor of gh comments

* wip

* udpates to language, should must etc

* Apply suggestions from code review

Co-authored-by: M. J. Fromberger <[email protected]>

* remove tendermint cache description

Co-authored-by: M. J. Fromberger <[email protected]>

* proto: add tendermint go changes (#349)

* add missed proto files

* add abci changes

* rename blockchain to blocksync

* Update proto/tendermint/abci/types.proto

Co-authored-by: Callum Waters <[email protected]>

Co-authored-by: Callum Waters <[email protected]>

* fix mockery generation script (#9094)

Signed-off-by: Marko Baricevic <[email protected]>
Co-authored-by: Milosevic, Zarko <[email protected]>
Co-authored-by: Milosevic, Zarko <[email protected]>
Co-authored-by: Zarko Milosevic <[email protected]>
Co-authored-by: Marko <[email protected]>
Co-authored-by: Zarko Milosevic <[email protected]>
Co-authored-by: Anton Kaliaev <[email protected]>
Co-authored-by: Anca Zamfir <[email protected]>
Co-authored-by: dongsamb <[email protected]>
Co-authored-by: Sunny Aggarwal <[email protected]>
Co-authored-by: Anca Zamfir <[email protected]>
Co-authored-by: Ethan Buchman <[email protected]>
Co-authored-by: Zarko Milosevic <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Zaki Manian <[email protected]>
Co-authored-by: Erik Grinaker <[email protected]>
Co-authored-by: Tess Rinearson <[email protected]>
Co-authored-by: Alexander Simmerl <[email protected]>
Co-authored-by: Igor Konnov <[email protected]>
Co-authored-by: Sean Braithwaite <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Josef Widder <[email protected]>
Co-authored-by: Andrey Kuprianov <[email protected]>
Co-authored-by: Igor Konnov <[email protected]>
Co-authored-by: Sam Hart <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Giuliano <[email protected]>
Co-authored-by: Shahan Khatchadourian <[email protected]>
Co-authored-by: Dev Ojha <[email protected]>
Co-authored-by: istoilkovska <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Sam Kleinman <[email protected]>
Co-authored-by: Sunny Aggarwal <[email protected]>
Co-authored-by: Federico Kunze <[email protected]>
Co-authored-by: Marko Baricevic <[email protected]>
Co-authored-by: Giuliano <[email protected]>
Co-authored-by: Jordan Sexton <[email protected]>
Co-authored-by: MengXiangJian <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
Co-authored-by: crypto-facs <[email protected]>
Co-authored-by: Giuliano <[email protected]>
Co-authored-by: William Banfield <[email protected]>
Co-authored-by: Mateusz Górski <[email protected]>
Co-authored-by: M. J. Fromberger <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
…on (#9275)

* config: Move discard_abci_responses flag into its own storage section

Signed-off-by: Thane Thomson <[email protected]>

* Update config comment to highlight space saving tradeoff

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
mergify bot and others added 16 commits October 10, 2022 15:24
* blocksync: retry requests after timeout (#9518)

* blocksync: retry requests after timeout

* Minimize changes to re-send block request after timeout

* TO REVERT: reduce queue capacity

* Add reset

* Revert "TO REVERT: reduce queue capacity"

This reverts commit dd0fee56924c958bed2ab7733e1917eb88fb5957.

* 30 seconds

* don't reset the timer

* Update blocksync/pool.go

Co-authored-by: Callum Waters <[email protected]>

Co-authored-by: Sergio Mena <[email protected]>
Co-authored-by: Callum Waters <[email protected]>
(cherry picked from commit a371b1e)

* Add changelog entry

Co-authored-by: William Banfield <[email protected]>
Co-authored-by: Sergio Mena <[email protected]>
Bumps [google.golang.org/grpc](https:/grpc/grpc-go) from 1.49.0 to 1.50.0.
- [Release notes](https:/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.49.0...v1.50.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Added print

* Fix unmarshall

* Fix unmarshalling

* Simplified steps to unmarshall

* minor

* Use 'encoding/hex'

* Forget about C, this is Go!

* gosec warning

* Set maximum payload size

* nosec annotation

(cherry picked from commit b42c439)

Co-authored-by: Sergio Mena <[email protected]>
…499) (#9578)

* QA Process report for v0.37.x (and baseline for v0.34.x) (#9499)

* 1st version. 200 nodes. Missing rotating node

* Small fixes

* Addressed @jmalicevic's comment

* Explain in method how to set the tmint version to test. Improve result section

* 1st version of how to run the 'rotating node' testnet

* Apply suggestions from @williambanfield

Co-authored-by: William Banfield <[email protected]>

* Addressed @williambanfield's comments

* Added reference to Unix load metric

* Added total TXs

* Fixed some 'png's that got swapped. Excluded '.*-node-exporter' processes from memory plots

* Report for rotating node

* Adressed remaining comments from @williambanfield

* Cosmetic

* Addressed some of @thanethomson's comments

* Re-executed the 200 node tests and updated the corresponding sections of the report

* Ignore Python virtualenv directories

Signed-off-by: Thane Thomson <[email protected]>

* Add latency vs throughput script

Signed-off-by: Thane Thomson <[email protected]>

* Add README for latency vs throughput script

Signed-off-by: Thane Thomson <[email protected]>

* Fix local links to folders

Signed-off-by: Thane Thomson <[email protected]>

* v034: only have one level-1 heading

Signed-off-by: Thane Thomson <[email protected]>

* Adjust headings

Signed-off-by: Thane Thomson <[email protected]>

* v0.37.x: add links to issues/PRs

Signed-off-by: Thane Thomson <[email protected]>

* v0.37.x: add note about bug being present in v0.34

Signed-off-by: Thane Thomson <[email protected]>

* method: adjust heading depths

Signed-off-by: Thane Thomson <[email protected]>

* Show data points on latency vs throughput plot

Signed-off-by: Thane Thomson <[email protected]>

* Add latency vs throughput plots

Signed-off-by: Thane Thomson <[email protected]>

* Correct mentioning of v0.34.21 and add heading

Signed-off-by: Thane Thomson <[email protected]>

* Refactor latency vs throughput script

Update the latency vs throughput script to rather generate plots from
the "raw" CSV output from the loadtime reporting tool as opposed to the
separated CSV files from the experimental method.

Also update the relevant documentation, and regenerate the images from
the raw CSV data (resulting in pretty much the same plots as the
previous ones).

Signed-off-by: Thane Thomson <[email protected]>

* Remove unused default duration const

Signed-off-by: Thane Thomson <[email protected]>

* Adjust experiment start time to be more accurate and re-plot latency vs throughput

Signed-off-by: Thane Thomson <[email protected]>

* Addressed @williambanfield's comments

* Apply suggestions from code review

Co-authored-by: William Banfield <[email protected]>

* Apply suggestions from code review

Co-authored-by: William Banfield <[email protected]>

* scripts: Update latency vs throughput readme for clarity

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: William Banfield <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
(cherry picked from commit b06e1ce)

* Remove v037 dir

* Removed reference to v0.37 testnets

Co-authored-by: Sergio Mena <[email protected]>
* fix: header link (#9574)

Co-authored-by: William Banfield <[email protected]>
(cherry picked from commit c8f2032)

# Conflicts:
#	spec/core/data_structures.md

* fix conflict

Co-authored-by: Rootul P <[email protected]>
Co-authored-by: William Banfield <[email protected]>
* Add changelog entry for v0.34.22

Signed-off-by: Thane Thomson <[email protected]>

* Prepare pending changelog for v0.34.23

Signed-off-by: Thane Thomson <[email protected]>

* Bump version to v0.34.22

Signed-off-by: Thane Thomson <[email protected]>

* Reword changelog entry regarding block sync issue

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
* ci: Fix linter complaint (#9645)

Fixes a very silly linter complaint that makes absolutely no sense and is blocking the merging of several PRs.

---

#### PR checklist

- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed

(cherry picked from commit 83b7f4a)

# Conflicts:
#	.github/workflows/lint.yml
#	.golangci.yml
#	cmd/tendermint/commands/debug/util.go

* Resolve conflicts

Signed-off-by: Thane Thomson <[email protected]>

* ci: Sync golangci-lint config with main

Minus the spelling configuration that restricts spelling to US English
only.

Signed-off-by: Thane Thomson <[email protected]>

* make format

Signed-off-by: Thane Thomson <[email protected]>

* Remove usage of deprecated io/ioutil package

Signed-off-by: Thane Thomson <[email protected]>

* Remove unused mockBlockStore

Signed-off-by: Thane Thomson <[email protected]>

* blockchain/v2: Remove unused method

Signed-off-by: Thane Thomson <[email protected]>

* Bulk fix lints

Signed-off-by: Thane Thomson <[email protected]>

* lint: Ignore auto-generated query PEG

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
…(#9641)

* p2p: add a per-message type send and receive metric (#9622)

* p2p: ressurrect the p2p envelope and use to calculate message metric

Add new SendEnvelope, TrySendEnvelope, BroadcastEnvelope, and ReceiveEnvelope methods in the p2p package to work with the new envelope type.

Care was taken to ensure this was performed in a non-breaking manner.

Co-authored-by: William Banfield <[email protected]>
Co-authored-by: William Banfield <[email protected]>
…592) (#9623)

* e2e: configurable IP addresses for e2e testnet generator (backport #9592)

* resurrect 'misbehavior'
Simple formatting issue.

---

#### PR checklist

- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed

(cherry picked from commit f58ba4d)

Co-authored-by: Lasaro Camargos <[email protected]>
* rpc: Add caching support (#9650)

* Set cache control in the HTTP-RPC response header

* Add a simply cache policy to the RPC routes

* add a condition to check the RPC request has default height settings

* fix cherry pick error

* update pending log

* use options struct intead of single parameter

* refacor FuncOptions to functional options

* add functional options in WebSocket RPC function

* revert doc

* replace deprecated function call

* revise functional options

* remove unuse comment

* fix revised error

* adjust cache-control settings

* Update rpc/jsonrpc/server/http_json_handler.go

Co-authored-by: Thane Thomson <[email protected]>

* linter: Fix false positive

Signed-off-by: Thane Thomson <[email protected]>

* rpc: Separate cacheable and non-cacheable HTTP response writers

Allows us to roll this change out in a non-API-breaking way, since this
is an additive change.

Signed-off-by: Thane Thomson <[email protected]>

* rpc: Ensure consistent caching strategy

Ensure a consistent caching strategy across both JSONRPC- and URI-based
requests.

This requires a bit of a refactor of the previous caching logic, which
is complicated a little by the complex reflection-based approach taken
in the Tendermint RPC.

Signed-off-by: Thane Thomson <[email protected]>

* rpc: Add more tests for caching

Signed-off-by: Thane Thomson <[email protected]>

* Update CHANGELOG_PENDING

Signed-off-by: Thane Thomson <[email protected]>

* light: Sync routes config with RPC core

Signed-off-by: Thane Thomson <[email protected]>

* rpc: Update OpenAPI docs

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: jayt106 <[email protected]>
Co-authored-by: jay tseng <[email protected]>
Co-authored-by: JayT106 <[email protected]>
(cherry picked from commit 816c6ba)

# Conflicts:
#	CHANGELOG_PENDING.md
#	light/proxy/routes.go
#	rpc/core/routes.go
#	rpc/openapi/openapi.yaml
#	test/fuzz/tests/rpc_jsonrpc_server_test.go

* Fix conflict in CHANGELOG_PENDING

Signed-off-by: Thane Thomson <[email protected]>

* Resolve remaining conflicts

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
* docs: Add new per-message type P2P metrics (#9676)

* docs: Monospace metric names

Signed-off-by: Thane Thomson <[email protected]>

* docs: Consistently capitalize metric types

Signed-off-by: Thane Thomson <[email protected]>

* docs: Monospace metric tags

Signed-off-by: Thane Thomson <[email protected]>

* docs: Fix underscores in metrics page

Signed-off-by: Thane Thomson <[email protected]>

* docs: Make metric description capitalization consistent

Signed-off-by: Thane Thomson <[email protected]>

* docs: Add new per-message P2P metrics

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
(cherry picked from commit 3aa6c81)

# Conflicts:
#	docs/tendermint-core/metrics.md

* Resolve conflicts

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
Co-authored-by: Thane Thomson <[email protected]>
* version: Bump to v0.34.23

Signed-off-by: Thane Thomson <[email protected]>

* Prepare changelog

Signed-off-by: Thane Thomson <[email protected]>

Signed-off-by: Thane Thomson <[email protected]>
@evan-forbes evan-forbes added the T:tendermint Type: upstream tendermint changes we want label Dec 12, 2022
@cmwaters
Copy link
Contributor Author

It seems like the p2p/mock/peer.go was manually updated to add the SendEnvelope and ReceiveEnvelope functions hence why the mock check is failing. I checked out v0.34.23 and when I run make mockery it removes these methods that have been added. Ideally we keep them in because they're needed to pass the tests else we need to modify the tests

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for handling this @cmwaters !

@evan-forbes
Copy link
Member

evan-forbes commented Dec 13, 2022

we can try to fix the generated code properly in a different PR imo, assuming it needs to be fixed

@cmwaters
Copy link
Contributor Author

The crux is that v0.34.23 changes the Peer interface but in order to make it non-breaking, a new interface was introduced:

type EnvelopeSender interface {
	SendEnvelope(Envelope) bool
	TrySendEnvelope(Envelope) bool
}

and a few shim functions were added to support the old Peer which has Send and the new Peer which has SendEnvelope (NOTE: in v0.37 the interface is then broken).

I'm going to merge this now but either we:

  1. rollback the tests in tendermint/tendermint@bdedf2e#diff-845bad6985bed7731e25d658c3bfbc7f5639ebf2a739b8074fe9614ce71941bc that change Send to SendEnvelope
  2. Turn off the mockery checker
  3. Bring the change in v0.37 forward such that the Peer interface has SendEnvelope as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:tendermint Type: upstream tendermint changes we want
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull upstream changes from Tendermint v0.34.23
7 participants