Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark issue in development #1640

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix benchmark issue in development #1640

merged 1 commit into from
Dec 1, 2023

Conversation

lemunozm
Copy link
Contributor

@lemunozm lemunozm commented Dec 1, 2023

The version of RuntimeChange with the FastDelay option was not the special case required for benchmarking

slack thread

@lemunozm lemunozm added P9-drop-everything Everyone should address this issue now. I1-fails The code fails withoug proper error handling. labels Dec 1, 2023
@lemunozm lemunozm requested a review from wischli December 1, 2023 21:41
@lemunozm lemunozm self-assigned this Dec 1, 2023
@lemunozm lemunozm enabled auto-merge (squash) December 1, 2023 21:41
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lemunozm lemunozm merged commit 8650c61 into main Dec 1, 2023
8 checks passed
@lemunozm lemunozm deleted the fix-benchmarks branch December 2, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I1-fails The code fails withoug proper error handling. P9-drop-everything Everyone should address this issue now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants