Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loans: Expand TransferDebt event with more info #1653

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

lemunozm
Copy link
Contributor

@lemunozm lemunozm added Q0-trivial An issure which is similar to patching code. I3-annoyance The code behaves as expected, but "expected" is an issue. P5-soon Issue should be addressed soon. D5-breaks-api Pull request changes public api. Document changes publicly. labels Dec 15, 2023
@lemunozm lemunozm self-assigned this Dec 15, 2023
@mustermeiszer
Copy link
Collaborator

Changes look good! @hieronx should we already rename or do we want to keep it for now as embrio needs to adapt then too?

@hieronx
Copy link
Contributor

hieronx commented Dec 15, 2023

I would keep it as is for now. The technical name still makes sense, and we don't know enough yet about loan refactor v4 (what this really ties into).

@lemunozm lemunozm merged commit 8e3faab into main Dec 15, 2023
9 checks passed
@lemunozm lemunozm deleted the loans/transfer-debt-event-ext branch December 15, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D5-breaks-api Pull request changes public api. Document changes publicly. I3-annoyance The code behaves as expected, but "expected" is an issue. P5-soon Issue should be addressed soon. Q0-trivial An issure which is similar to patching code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants