Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remarks: Add pool ID to loan variant #1682

Merged
merged 2 commits into from
Jan 8, 2024
Merged

remarks: Add pool ID to loan variant #1682

merged 2 commits into from
Jan 8, 2024

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Jan 8, 2024 •
edited
Loading

Description

Loan IDs are not unique, therefore, we need to add the PoolId to the Loan variant of the Remark enum.

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

lemunozm
lemunozm approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdamian cdamian merged commit 045aed8 into main Jan 8, 2024
9 checks passed
@cdamian cdamian deleted the add-pool-id-to-loan-remark-enum branch January 8, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemunozm lemunozm lemunozm approved these changes

@wischli wischli wischli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdamian @lemunozm @wischli