fix: looser is_local_representation
#1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
previously approved these changes
Apr 17, 2024
| Ok(self == &local) | ||
| Ok(self == &local.into()) | ||
| } else { | ||
| Ok(false) |
| #[test] | ||
| fn is_local_happy_paths() { | ||
| new_test_ext().execute_with(|| { | ||
| assert_eq!(<CurrencyId as HasLocalAssetRepresentation<MockRegistry>>::is_local_representation_of(&USDC_LOCAL, &USDC_1), Ok(true)); |
There was a problem hiding this comment.
Just curious,
CurrencyId::is_local_representation_of()Does not compile? Does the compiler force you to specify the trait?
There was a problem hiding this comment.
Unfortunately not, the AssetInspect parameter type cannot be inferred. Tried different variants but none of the shortcuts worked.
mustermeiszer
previously approved these changes
Apr 17, 2024
* add tests that fail and shouldn't * add fix * add extra tests
mustermeiszer
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue which blocks FRAX <> USDC order fulfilments on Demo.
The current implementation of
is_local_representationis too strict such that it throws an error if the checkedCurrencyIdhas not configured a local representation. Instead, it should returnOk(false). This function has not been tested directly.To the best of my knowledge, this does not affect production for now as it only affects checking currencies which don't have a configured local asset, e.g. FRAX.
Checklist: