Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Make min epoch time in dev smaller #1872

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

mustermeiszer
Copy link
Collaborator

@mustermeiszer mustermeiszer commented Jun 13, 2024

Description

DefaultMinEpochTime was 5 minutes beforehand. Which made creating pools in dev annoying, as you need to wait 5 minutes to bring in investments. Now, this is all possible in 1 blocks.

Changes and Descriptions

  • Change runtime configuration to allow closing multiple epochs per block
  • Change runtime configuration to have a minimum default epoch time of 0

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@mustermeiszer mustermeiszer added the D0-ready Pull request can be merged without special precaution and notification. label Jun 13, 2024
@mustermeiszer mustermeiszer enabled auto-merge (squash) June 13, 2024 10:44
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, this is all possible in 2 blocks.

Why 2 blocks and no 1?

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.76%. Comparing base (4363f8b) to head (4b50c5f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
+ Coverage   46.73%   46.76%   +0.03%     
==========================================
  Files         169      169              
  Lines       13177    13176       -1     
==========================================
+ Hits         6158     6162       +4     
+ Misses       7019     7014       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mustermeiszer
Copy link
Collaborator Author

It is possible in one block

@mustermeiszer
Copy link
Collaborator Author

@lemunozm lets see if this goes through #1873

@mustermeiszer mustermeiszer merged commit f750138 into main Jun 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-ready Pull request can be merged without special precaution and notification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants