Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs: add clone progress report in clone status #1036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nikhil-Ladha
Copy link
Contributor

Add clone progress report in clone status output

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@Nikhil-Ladha
Copy link
Contributor Author

Ref issue: ceph/ceph-csi#4813

@phlogistonjohn phlogistonjohn added the API This PR includes a change to the public API of a go-ceph package label Oct 17, 2024
@phlogistonjohn
Copy link
Collaborator

I see that this is an admin API, so it should be populating the new struct via JSON. However, I would like to see tests for this prior to approval.

@Nikhil-Ladha
Copy link
Contributor Author

I see that this is an admin API, so it should be populating the new struct via JSON. However, I would like to see tests for this prior to approval.

Tests as in that the json/struct is populated correctly or something else?

@phlogistonjohn
Copy link
Collaborator

phlogistonjohn commented Oct 17, 2024

Tests as in that the json/struct is populated correctly

That would be fine thanks.

@Nikhil-Ladha
Copy link
Contributor Author

I have added a json sample for test TestParseCloneStatus under clone_test.go file, hope that helps.
I have tested locally the TestCloneSubVolumeSnapshot with fmt.Printf() statements under parseCloneStatus function and the value was propagated properly.

add clone progress report in clone status output

Signed-off-by: Nikhil-Ladha <[email protected]>
@@ -27,6 +27,11 @@ var sampleCloneStatusInProg = []byte(`{
"volume": "cephfs",
"subvolume": "subvol1",
"snapshot": "snap1"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please correct the formatting/indention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants