Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to v1.10.18 versions of vdb geth #6

Closed
2 tasks done
Tracked by #231
i-norden opened this issue May 25, 2022 · 3 comments · Fixed by #13
Closed
2 tasks done
Tracked by #231

Rebase to v1.10.18 versions of vdb geth #6

i-norden opened this issue May 25, 2022 · 3 comments · Fixed by #13

Comments

@i-norden
Copy link
Contributor

i-norden commented May 25, 2022

Child of cerc-io/go-ethereum#231

This may also involve updating the dependencies on ipfs-ethdb and ipld-eth-server to the versions resultant of cerc-io/ipfs-ethdb#34 and cerc-io/ipld-eth-server#158

@abdulrabbani00
Copy link
Contributor

abdulrabbani00 commented May 31, 2022

@abdulrabbani00
Copy link
Contributor

@ashwinphatak - I see that you and your team have been actively contributing to this repo in the last few hours. Should I wait to cut the v4 release? Steps I plan on taking when it is time to cut the release.

  1. Branch off of sharding --> feature/update-go-geth-sharding
  2. git merge main into feature/update-go-geth-sharding
  3. Handle any conflicts.
  4. Create a PR: feature/update-go-geth-sharding --> sharding
  5. Create a tagged release.

@prathamesh0
Copy link
Contributor

@abdulrabbani00 We are done with the changes to main for now. The steps you mentioned for merging the changes into sharding sound good. You can refer to #11 while resolving conflicts.

@abdulrabbani00 abdulrabbani00 linked a pull request Jun 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants