Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP pipeline: arguments are ignored #1875

Closed
ghost opened this issue Apr 19, 2021 · 0 comments · Fixed by #1996
Closed

AMQP pipeline: arguments are ignored #1875

ghost opened this issue Apr 19, 2021 · 0 comments · Fixed by #1996
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Milestone

Comments

@ghost
Copy link

ghost commented Apr 19, 2021

self.host = getattr(self,
"{}_pipeline_host".format(queues_type),
"127.0.0.1")
self.port = getattr(self,
"{}_pipeline_port".format(queues_type), 5672)
self.username = getattr(self,
"{}_pipeline_username".format(queues_type),
None)
self.password = getattr(self,
"{}_pipeline_password".format(queues_type),
None)
# socket_timeout is None by default, which means no timeout
self.socket_timeout = getattr(self,
"{}_pipeline_socket_timeout".format(
queues_type),
None)
self.load_balance = getattr(self, "load_balance", False)
self.virtual_host = getattr(self,
"{}_pipeline_amqp_virtual_host".format(queues_type),
'/')
self.ssl = getattr(self, "{}_pipeline_ssl".format(queues_type), False)
self.exchange = getattr(self, "{}_pipeline_amqp_exchange".format(queues_type), "")

The amqp class accesses self to get the parameters, while the redis class uses self.pipeline_args. The amqp pipeline does not receive any parameters because of that bug.

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: core labels Apr 19, 2021
@ghost ghost added this to the 3.0.0 milestone Apr 19, 2021
@ghost ghost self-assigned this Jun 17, 2021
ghost pushed a commit that referenced this issue Jun 17, 2021
the arguments given by pipeline_args were not effective, as the
load_configuration methods of the pipeline classes still tried to access
the parameters at self.

also modify the tests to catch a bug like this in the future

fixes #1875
ghost pushed a commit that referenced this issue Jun 17, 2021
the arguments given by pipeline_args were not effective, as the
load_configuration methods of the pipeline classes still tried to access
the parameters at self.

also modify the tests to catch a bug like this in the future

fixes #1875
@ghost ghost closed this as completed in c6ecca3 Jun 21, 2021
waldbauer-certat pushed a commit that referenced this issue May 31, 2022
the arguments given by pipeline_args were not effective, as the
load_configuration methods of the pipeline classes still tried to access
the parameters at self.

also modify the tests to catch a bug like this in the future

fixes #1875
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants