Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exceeding dumping #994

Closed
e3rd opened this issue Jun 5, 2017 · 2 comments
Closed

exceeding dumping #994

e3rd opened this issue Jun 5, 2017 · 2 comments
Labels
component: core feature Indicates new feature requests or new features
Milestone

Comments

@e3rd
Copy link
Member

e3rd commented Jun 5, 2017

In the case of an error, the raw message gets dumped.
It happened to me that the same message got dumped again and again (due to an error in alien-vault-otx). When the dump exceeded 8 GB, the json module wasn't able to load it and bot.py stucked at dump_data = json.load(fp). In the morning, the bot was stopped, no hint in logs, nothing nowhere.

In the case of dump, shouldn't we check for exactly the same data in the file first? We may add a field occurences_number or so to the dumpfile json.

@ghost
Copy link

ghost commented Jun 6, 2017

See also #574 #869 #870
Saving a message per line does fix the 8GB limit error too. And then we could even check if the last existing line is the same as the one we are just trying to dump.

If we implement this occurences_number we need to recover it multiple times too.

But primarily we should fix the bugs in the bots themselves so this can't happen at all.

@ghost ghost added component: core feature Indicates new feature requests or new features labels Jun 6, 2017
@ghost ghost added this to the v1.1 Feature release milestone Jun 6, 2017
@e3rd
Copy link
Member Author

e3rd commented Jun 8, 2017

Thanks, I should've search for the error in the issues more thoroughly before.
Closing as DUPLICATE.

@e3rd e3rd closed this as completed Jun 8, 2017
@ghost ghost modified the milestones: v1.1 Feature release, v1.0 Stable Release Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core feature Indicates new feature requests or new features
Projects
None yet
Development

No branches or pull requests

1 participant