Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowserver Accessible Cisco Smart Install with tests and docs #1122

Merged
2 commits merged into from Nov 27, 2017
Merged

Shadowserver Accessible Cisco Smart Install with tests and docs #1122

2 commits merged into from Nov 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2017

Based on #1121 with added docs and tests

@ghost ghost added the component: bots label Nov 21, 2017
@ghost ghost added this to the 1.0.3 milestone Nov 21, 2017
@codecov-io
Copy link

Codecov Report

Merging #1122 into maintenance will increase coverage by 0.06%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           maintenance    #1122      +/-   ##
===============================================
+ Coverage        75.19%   75.26%   +0.06%     
===============================================
  Files              216      217       +1     
  Lines             9197     9220      +23     
  Branches          1245     1246       +1     
===============================================
+ Hits              6916     6939      +23     
  Misses            1996     1996              
  Partials           285      285
Impacted Files Coverage Δ
intelmq/bots/parsers/shadowserver/config.py 85.55% <100%> (+0.16%) ⬆️
...hadowserver/test_accessible_cisco_smart_install.py 100% <100%> (ø)

Copy link
Member

@aaronkaplan aaronkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, thanks a lot for the contribution!

@ghost ghost merged commit d39d93d into certtools:maintenance Nov 27, 2017
@ghost ghost deleted the my-pr-1121 branch December 20, 2017 14:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants